Fix bug #2
Open
Fix bug #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix overflow error Add ymback's info to README.md Signed-off-by: ymback <ymback@sayyoulove.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blizzard use new auth api hosts as the file shows, different region have different api host, actually we can use https to access, in my site, I use curl to access the https api hosts.
The function elapsedtime() in file 'Authenticator.php' has a overflow bug, which may return minus value, fixed.
I have builded a site, modify Authenticator class and use it as a library, so does it possible to add my info to "Who use it" in the README.md.
Signed-off-by: ymback ymback@sayyoulove.me