Merged
Conversation
krtr
approved these changes
Oct 14, 2018
Owner
|
@VitorLuizC looks great 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again! I was working on krtr/TibiaJS#14 and realized that to fix it I needed to transform the SpriteGL into a module. This also allows others to use SpriteGL more easily.
✨ Generates the CommonJS, ESM, UMD and minified UMD bundles using Bili
✨ Generates type definitions
🔧 Changes
package.jsonto point to the right bundles and the type definitions📦 I used Parcel to compile and start the example files
✅ Fixed some indentation inconsistencies and using TypeScript
🏗️ I modified the file structure for the common JavaScript / TypeScript modules
🔥 Removed Visual Studio references, but add them again if necessary
🔥 Removes Gulp and it's dependencies
📝 I wrote the documentation in the README to install and run the demo