Skip to content

SpriteGL as a module#4

Merged
krtr merged 8 commits intokrtr:masterfrom
VitorLuizC:master
Oct 14, 2018
Merged

SpriteGL as a module#4
krtr merged 8 commits intokrtr:masterfrom
VitorLuizC:master

Conversation

@VitorLuizC
Copy link
Contributor

Hello again! I was working on krtr/TibiaJS#14 and realized that to fix it I needed to transform the SpriteGL into a module. This also allows others to use SpriteGL more easily.

While @matthiasferch does not accept my PR I am using my own fork as a dependency. However, as soon as he accepts I make a new PR to import from his repository

  • ✨ Generates the CommonJS, ESM, UMD and minified UMD bundles using Bili

  • ✨ Generates type definitions

  • 🔧 Changes package.json to point to the right bundles and the type definitions

  • 📦 I used Parcel to compile and start the example files

  • ✅ Fixed some indentation inconsistencies and using TypeScript

  • 🏗️ I modified the file structure for the common JavaScript / TypeScript modules

  • 🔥 Removed Visual Studio references, but add them again if necessary

  • 🔥 Removes Gulp and it's dependencies

  • 📝 I wrote the documentation in the README to install and run the demo

@krtr
Copy link
Owner

krtr commented Oct 14, 2018

@VitorLuizC looks great 👍

@krtr krtr merged commit 7526893 into krtr:master Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants