Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/admin-guide/gatewayapi-migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ kubectl apply -f https://github.com/kubernetes-sigs/gateway-api/releases/downloa

## 2. Create GatewayClass

Create a `GatewayClass` resource using your preferred network controller. For this example, we will use [Envoy Gateway](https://gateway.envoyproxy.io/docs/) as the network controller.
Create a `GatewayClass` resource using your preferred network controller. For this example, we will use [Envoy Gateway](https://gateway.envoyproxy.io/docs/) as the network controller. **Note:** Kserve requires Envoy Gateway **v1.3.0**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using 1.5.0 now (https://github.com/kserve/kserve/blob/master/kserve-deps.env#L18C1-L18C22)

We now centralized all the dependencies in a single file in kserve so I think we need some automation to update this version based on the file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're trying to describe the minimum version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This applies specifically to Kserve 0.16. Mainline uses more updated versions and this will need to be changed when we perform a release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is for 0.16, then it should be updated here. The src/ dir for the nightly version (latest master).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Create a `GatewayClass` resource using your preferred network controller. For this example, we will use [Envoy Gateway](https://gateway.envoyproxy.io/docs/) as the network controller. **Note:** Kserve requires Envoy Gateway **v1.3.0**.
Create a `GatewayClass` resource using your preferred network controller. For this example, we will use [Envoy Gateway](https://gateway.envoyproxy.io/docs/) as the network controller. **Note:** KServe requires Envoy Gateway **v1.3.0**.


```yaml
apiVersion: gateway.networking.k8s.io/v1
Expand Down