Skip to content

Added option to optimize numeric data types #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WandererTM wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added option to optimize numeric data types #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/pgdbf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
#include <sys/types.h>

#include "pgdbf.h"
#define STANDARDOPTS "cCdDeEhm:i:nNpPqQrRtTuU"
#define STANDARDOPTS "cCdDeEhm:i:nNopPqQrRtTuU"

int main(int argc, char **argv) {
/* Describing the DBF file */
Expand Down Expand Up @@ -112,6 +112,7 @@ int main(int argc, char **argv) {
int optusetransaction = 1;
int optusetruncatetable = 0;
int opttrimpadding = 1;
int optoptimizenums = 0;

/* Describing the PostgreSQL table */
char *tablename;
Expand Down Expand Up @@ -183,6 +184,9 @@ int main(int argc, char **argv) {
case 'N':
optnumericasnumeric = 0;
break;
case 'o':
optoptimizenums = 1;
break;
case 'p':
optshowprogress = 1;
break;
Expand Down Expand Up @@ -255,6 +259,7 @@ int main(int argc, char **argv) {
" -m the name of the associated memo file (if necessary)\n"
" -n use type 'NUMERIC' for NUMERIC fields (default)\n"
" -N use type 'TEXT' for NUMERIC fields\n"
" -o optimize numeric data types (use SMALLINT,INTEGER and BIGINT instead of NUMBER(n) where applicable)\n"
" -r remove padding at the end of TEXT and VARCHAR fields (default)\n"
" -R keep padding at the end of TEXT and VARCHAR fields\n"
" -p show a progress bar during processing\n"
Expand Down Expand Up @@ -621,7 +626,18 @@ int main(int argc, char **argv) {
if(fields[fieldnum].decimals > 0) {
printf("NUMERIC(%d, %d)", fields[fieldnum].length, fields[fieldnum].decimals);
} else {
printf("NUMERIC(%d)", fields[fieldnum].length);
if(optoptimizenums) {
if(fields[fieldnum].length < 5)
printf("SMALLINT");
else if(fields[fieldnum].length < 10)
printf("INTEGER");
else if(fields[fieldnum].length < 19)
printf("BIGINT");
else
printf("NUMERIC(%d)", fields[fieldnum].length);
}
else
printf("NUMERIC(%d)", fields[fieldnum].length);
}
} else {
printf("TEXT");
Expand Down