-
Notifications
You must be signed in to change notification settings - Fork 172
Add GIP-MI reliability framework example reference #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Welcome @niuchaoyu! It looks like this is your first PR to kubeedge/examples 🎉 |
Summary of ChangesHello @niuchaoyu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates documentation for the GIP-MI reliability framework, providing an example reference for software aging prediction and node rejuvenation within the KubeEdge ecosystem. It serves as an introductory guide to the framework's core components and directs users to the complete implementation and related discussions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: niuchaoyu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a README file for the GIP-MI reliability framework example. The content is clear and provides a good overview. I have a couple of suggestions to improve the readability and user experience of the markdown file by making references into clickable links with descriptive text.
fujitatomoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for your contribution interest.
actually i have concerns about accepting this PR: (i am not a maintainer of this repository, but this could be applied in general for oss project management.)
- External code reference: The kubeedge/examples repository maintains example code directly, not references to external repositories. This ensures maintainability and that examples remain functional.
- Maintainability: Code hosted in personal repositories can break or disappear without notice, and maintainers cannot fix issues.
- Scope: Examples here typically demonstrate core KubeEdge features (device mappers, edge applications, etc.).
what do you think... ? @niuchaoyu @Shelley-BaoYue
Hi @fujitatomoya, thank you for the feedback. You are absolutely right. I agree that relying on an external repository is not ideal for long-term maintainability and consistency. I will push the updates shortly. Thanks for guiding me to follow the best practices! |
Signed-off-by: niuchaoyu <411654689@qq.com>
This PR adds a reference to the GIP-MI reliability solution discussed in kubeedge/kubeedge#6607.