Update Troubleshooting Guide with v1.21 and Feedback from #726#729
Update Troubleshooting Guide with v1.21 and Feedback from #726#729sachin21212121 wants to merge 1 commit intokubeedge:masterfrom
Conversation
…ting Signed-off-by: sachin21212121 <jhasachin0115@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @sachin21212121, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly overhauls the KubeEdge troubleshooting documentation. The primary goal is to provide clearer, more up-to-date guidance for users encountering common issues during setup and operation, particularly concerning Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request provides a much-needed update to the troubleshooting guide, bringing it up to date with KubeEdge v1.21.0. The restructuring of the content and the addition of new troubleshooting steps for pod states and logging significantly improve the document's clarity and usefulness. However, I've identified a critical formatting issue where the entire file has been wrapped in a markdown code block, which will prevent the page from rendering correctly. Additionally, the links for downloading CRD files are incorrect. My review includes suggestions to fix these issues and a minor change to improve structural consistency.
|
|
||
| ````markdown |
There was a problem hiding this comment.
The file starts with a blank line and a markdown code fence. This is invalid and will cause rendering issues. The YAML frontmatter must be at the very beginning of the file, and the markdown fence is causing the entire document to be treated as a code block. Please remove the blank line and the fence.
| ``` | ||
| ``` |
| - [devices_v1beta1_device.yaml](https://github.com/kubeedge/kubeedge/blob/v1.21.0/build/crds/devices/devices_v1beta1_device.yaml) | ||
| - [devices_v1beta1_devicemodel.yaml](https://github.com/kubeedge/kubeedge/blob/v1.21.0/build/crds/devices/devices_v1beta1_devicemodel.yaml) | ||
| - [cluster_objectsync_v1alpha1.yaml](https://github.com/kubeedge/kubeedge/blob/v1.21.0/build/crds/reliablesyncs/cluster_objectsync_v1alpha1.yaml) | ||
| - [objectsync_v1alpha1.yaml](https://github.com/kubeedge/kubeedge/blob/v1.21.0/build/crds/reliablesyncs/objectsync_v1alpha1.yaml) |
There was a problem hiding this comment.
The links to the CRD YAML files point to the GitHub HTML view (github.com/.../blob/...) instead of the raw file content. This will prevent users from downloading the files directly using tools like wget or curl. Please update the links to point to the raw content on raw.githubusercontent.com.
| - [devices_v1beta1_device.yaml](https://github.com/kubeedge/kubeedge/blob/v1.21.0/build/crds/devices/devices_v1beta1_device.yaml) | |
| - [devices_v1beta1_devicemodel.yaml](https://github.com/kubeedge/kubeedge/blob/v1.21.0/build/crds/devices/devices_v1beta1_devicemodel.yaml) | |
| - [cluster_objectsync_v1alpha1.yaml](https://github.com/kubeedge/kubeedge/blob/v1.21.0/build/crds/reliablesyncs/cluster_objectsync_v1alpha1.yaml) | |
| - [objectsync_v1alpha1.yaml](https://github.com/kubeedge/kubeedge/blob/v1.21.0/build/crds/reliablesyncs/objectsync_v1alpha1.yaml) | |
| - [devices_v1beta1_device.yaml](https://raw.githubusercontent.com/kubeedge/kubeedge/v1.21.0/build/crds/devices/devices_v1beta1_device.yaml) | |
| - [devices_v1beta1_devicemodel.yaml](https://raw.githubusercontent.com/kubeedge/kubeedge/v1.21.0/build/crds/devices/devices_v1beta1_devicemodel.yaml) | |
| - [cluster_objectsync_v1alpha1.yaml](https://raw.githubusercontent.com/kubeedge/kubeedge/v1.21.0/build/crds/reliablesyncs/cluster_objectsync_v1alpha1.yaml) | |
| - [objectsync_v1alpha1.yaml](https://raw.githubusercontent.com/kubeedge/kubeedge/v1.21.0/build/crds/reliablesyncs/objectsync_v1alpha1.yaml) |
| └── kubeedge-v1.21.0-linux-amd64.tar.gz | ||
| ```` | ||
|
|
||
| **Run keadm init with version flag** |
This PR updates the troubleshooting guide with:
Steps for fixing keadm init download failures.
Correct CRD references for v1.21.0.
Additional troubleshooting for Pending/Terminating pods.
Logging instructions for CloudCore, EdgeCore, and Pods.
Updates based on feedback from Shelley in update troubleshooting guide with CRD links and improved formatting #726
.