add more contents to build procedure page for kubeedge.#760
add more contents to build procedure page for kubeedge.#760fujitatomoya wants to merge 1 commit intokubeedge:masterfrom
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @fujitatomoya, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the KubeEdge build procedure documentation. It provides comprehensive and up-to-date instructions for developers, covering prerequisites, various build configurations (including component-specific, cross-platform, and optimized builds), a full suite of testing procedures (linting, verification, unit, integration, and E2E tests), installation steps, and release processes. The update aims to align the documentation with the current KubeEdge Makefile, making it more accurate and user-friendly. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request significantly improves the build procedure documentation by adding detailed explanations and examples for various make targets. The new structure is much clearer and more comprehensive. I have a couple of suggestions to further improve clarity and prevent potential user errors, mainly regarding prerequisite installation and consistency in build commands.
| ```bash | ||
| # Download and install the latest yq binary (platform-specific) | ||
| # For Linux (amd64) | ||
| wget https://github.com/mikefarah/yq/releases/latest/download/yq_linux_amd64 -O /usr/local/bin/yq && chmod +x /usr/local/bin/yq |
There was a problem hiding this comment.
This command will likely fail due to permission errors since it writes to /usr/local/bin. It's better to prepend sudo to both wget and chmod to avoid this.
Additionally, for macOS users, it would be clearer to recommend installing yq via Homebrew (brew install yq) alongside the other tools, rather than pointing them to this manual installation section.
| wget https://github.com/mikefarah/yq/releases/latest/download/yq_linux_amd64 -O /usr/local/bin/yq && chmod +x /usr/local/bin/yq | |
| sudo wget https://github.com/mikefarah/yq/releases/latest/download/yq_linux_amd64 -O /usr/local/bin/yq && sudo chmod +x /usr/local/bin/yq |
| Build all KubeEdge binaries: | ||
|
|
||
| ```bash | ||
| make |
fujitatomoya
left a comment
There was a problem hiding this comment.
@Shelley-BaoYue can you have a quick look at this? this is just straight-forward enhancement aligned with current https://github.com/kubeedge/kubeedge/blob/master/Makefile
|
@Shelley-BaoYue btw, who is the active reviewer or maintainer to monitor this repository? |
| @@ -6,13 +6,24 @@ sidebar_position: 1 | |||
| ## Prerequisites | |||
|
|
|||
| * A recent Go distribution (>=1.16) | |||
There was a problem hiding this comment.
| * A recent Go distribution (>=1.16) | |
| * A recent Go distribution (>=1.21) |
go version can also be updated : )
Recently, seems only me 😢 |
Which issue(s) this PR fixes:
Closes #759
Build procedure documentation quality enhancement
Out of dated, not well enough described.
Up to date with current Makefile from KubeEdge
No
None