feat(trainer): implement get_gpu_status for Kubernetesbackend#251
Open
haroon0x wants to merge 1 commit intokubeflow:mainfrom
Open
feat(trainer): implement get_gpu_status for Kubernetesbackend#251haroon0x wants to merge 1 commit intokubeflow:mainfrom
haroon0x wants to merge 1 commit intokubeflow:mainfrom
Conversation
Signed-off-by: haroon0x <haroonbmc0@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
🎉 Welcome to the Kubeflow SDK! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements the
get_gpu_statusmethod in theKubernetesBackend, allowing users to retrieve real-time GPU metrics from training pods. This feature enhances observability for AI workloads by providing structured data on GPU utilization, memory usage, temperature, power draw, and performance states.Key technical changes:
get_gpu_statusas an abstract method inRuntimeBackend.get_gpu_status(job_name)inTrainerClient.execAPI to runnvidia-smiinside training pods (node-*). It uses a structured CSV query format (--query-gpu=...) for reliable parsing.LocalProcessBackendandContainerBackendto ensure all backends satisfy the revised interface.test_get_gpu_statustokubeflow/trainer/backends/kubernetes/backend_test.pywhich mocks the Kubernetes stream response.Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #165
Checklist: