fix(sdk): always add queue label regardless of queue existence#3221
Open
puwun wants to merge 1 commit intokubeflow:release-1.9from
Open
fix(sdk): always add queue label regardless of queue existence#3221puwun wants to merge 1 commit intokubeflow:release-1.9from
puwun wants to merge 1 commit intokubeflow:release-1.9from
Conversation
Fixes kubeflow#2775 Signed-off-by: Pavan More <pavansmore05@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow Trainer! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
create_job()skips adding thekueue.x-k8s.io/queue-namelabel when the specified local-queue doesn't exist, preventing Kueue from ever managing the job. Removed the conditional gate so the label is always added whenqueue_nameis provided.Changes:
if queue_exists is not Falsecondition that gated label addition,_check_queue_exists()is still called for its side effects (warning logs, error handling)Which issue(s) this PR fixes:
Fixes #2775