Skip to content

fix(sdk): always add queue label regardless of queue existence#3221

Open
puwun wants to merge 1 commit intokubeflow:release-1.9from
puwun:fix/queue-validation
Open

fix(sdk): always add queue label regardless of queue existence#3221
puwun wants to merge 1 commit intokubeflow:release-1.9from
puwun:fix/queue-validation

Conversation

@puwun
Copy link
Contributor

@puwun puwun commented Feb 18, 2026

What this PR does / why we need it:
create_job() skips adding the kueue.x-k8s.io/queue-name label when the specified local-queue doesn't exist, preventing Kueue from ever managing the job. Removed the conditional gate so the label is always added when queue_name is provided.

Changes:

  • Removed the if queue_exists is not False condition that gated label addition, _check_queue_exists() is still called for its side effects (warning logs, error handling)
  • Updated the "valid flow with non-existent queue" test case to expect the queue label

Which issue(s) this PR fixes:
Fixes #2775

Fixes kubeflow#2775

Signed-off-by: Pavan More <pavansmore05@gmail.com>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jinchihe for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

🎉 Welcome to the Kubeflow Trainer! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards.
  • Our team will review your PR soon! cc @kubeflow/kubeflow-trainer-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments