feat: Code Quality Checks workflow#3223
Closed
Goku2099 wants to merge 8 commits intokubeflow:masterfrom
Closed
Conversation
…linter (Fixes kubeflow#3096) Signed-off-by: juyterman1000 <fastrunner10090@gmail.com>
Signed-off-by: juyterman1000 <fastrunner10090@gmail.com>
Adds "make kube-linter" to download the binary and "make lint-manifests" to run kube-linter on manifests and helm charts locally. Signed-off-by: juyterman1000 <fastrunner10090@gmail.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Goku2099
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a consolidated Code Quality Checks workflow to centralize quality-related CI checks, making it easier to extend with additional checks (e.g., helm lint, formatting) incrementally. Currently includes kube-linter validation for Kubernetes manifests and Helm charts.
Changes:
- Added new GitHub Actions workflow for code quality checks
- Introduced kube-linter configuration and Makefile targets
- Bumped Helm chart version from 2.1.0 to 2.1.1
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| .github/workflows/code-quality-check.yaml | New workflow that runs manifest and Helm chart linting |
| .kube-linter.yaml | Configuration file for kube-linter with excluded checks |
| Makefile | Added kube-linter installation and lint-manifests targets |
| charts/kubeflow-trainer/Chart.yaml | Version bump from 2.1.0 to 2.1.1 |
Pull Request Test Coverage Report for Build 22149261691Details
💛 - Coveralls |
Goku2099
force-pushed
the
code-quality-check
branch
from
080ce7a to
807e134
Compare
…ck Code Quality Checks workflow Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Goku2099
force-pushed
the
code-quality-check
branch
from
807e134 to
f6a095c
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
Goku2099
force-pushed
the
code-quality-check
branch
from
6fb79ba to
a9f5445
Compare
…ck Code Quality Checks workflow Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Goku2099
force-pushed
the
code-quality-check
branch
from
a9f5445 to
ab862f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a consolidated Code Quality Checks workflow.
The intention is to consolidate quality-related CI checks in one place so we can extend it incrementally (helm lint, formatting, etc.) without scattering workflows.
Currently includes:
Follow-up PR: #3101