Skip to content

feat: Code Quality Checks workflow#3224

Open
Goku2099 wants to merge 8 commits intokubeflow:masterfrom
Goku2099:code-quality-clean
Open

feat: Code Quality Checks workflow#3224
Goku2099 wants to merge 8 commits intokubeflow:masterfrom
Goku2099:code-quality-clean

Conversation

@Goku2099
Copy link
Contributor

Introduces a consolidated Code Quality Checks workflow.

The intention is to consolidate quality-related CI checks in one place so we can extend it incrementally (helm lint, formatting, etc.) without scattering workflows.

Currently includes:

kube-linter checks for manifests and Helm charts
Follow-up PR: #3101

Copilot AI review requested due to automatic review settings February 18, 2026 17:44
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jeffwan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Feb 18, 2026

Pull Request Test Coverage Report for Build 22154737482

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.998%

Totals Coverage Status
Change from base Build 22133652847: 0.0%
Covered Lines: 1391
Relevant Lines: 2484

💛 - Coveralls

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a consolidated Code Quality Checks workflow to centralize quality-related CI checks. The workflow currently includes kube-linter for validating Kubernetes manifests and Helm charts, and integrates helm-lint testing. This consolidation enables incremental extension of quality checks (formatting, additional linters, etc.) in a single location.

Changes:

  • Added kube-linter configuration and Makefile targets for manifest/chart validation
  • Created new GitHub Actions workflow for running code quality checks
  • Parameterized helm-lint target branch for flexibility in CI

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
Makefile Added kube-linter version, installation target, and lint-manifests target; parameterized helm-lint with TARGET_BRANCH
.kube-linter.yaml Configuration file excluding specific checks (resource requirements, selectors, security contexts) that may not apply to all manifests
.github/workflows/code-quality-check.yaml New workflow running kube-linter and helm-lint on push/PR events with repository check

@Goku2099 Goku2099 force-pushed the code-quality-clean branch 2 times, most recently from 53eedab to 001f801 Compare February 18, 2026 19:37
@Goku2099
Copy link
Contributor Author

hi @andreyvelich The GPU E2E failure appears unrelated to this PR.
This change only introduces the Code Quality workflow and does not modify E2E setup, runtimes, or cluster configuration.
Please let me know if you’d like me to investigate separately.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @Goku2099!
I left a few comments, overall looks good.

@Goku2099
Copy link
Contributor Author

hi @andreyvelich
I’ve added Helm unit tests to the Code Quality Checks workflow.
Since the unittest coverage is now included here, I’ve closed PR #3166 to avoid duplication.
Please let me know if you’d prefer any adjustments.

@andreyvelich
Copy link
Member

Can you check why CI is failing @Goku2099 ?

@Goku2099
Copy link
Contributor Author

Goku2099 commented Feb 19, 2026

@andreyvelich
CI is failing in the Helm unit tests because the test suite references templates/runtimes/torch-distributed-with-cache.yaml, while the actual template is under templates/runtimes/data-cache/. I’m currently running the Helm unit tests locally and will push a fix after verifying it.

@Goku2099
Copy link
Contributor Author

@andreyvelich
The Helm unit test failures were due to inconsistencies in the torch-distributed-with-cache template logic. I’ve addressed those in a separate PR #3226.

With that fix in place, the Code Quality workflow should be fully green.
Could you please take a look and let me know if everything looks good for merge?

@andreyvelich
Copy link
Member

@Goku2099 Since #3226 has been merged, please can you rebase this PR to fix the CI ?

Goku2099 and others added 5 commits February 20, 2026 00:44
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
@Goku2099 Goku2099 force-pushed the code-quality-clean branch 2 times, most recently from e05828c to 53f35f9 Compare February 19, 2026 19:28
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments