feat: Code Quality Checks workflow#3224
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 22154737482Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull request overview
This PR introduces a consolidated Code Quality Checks workflow to centralize quality-related CI checks. The workflow currently includes kube-linter for validating Kubernetes manifests and Helm charts, and integrates helm-lint testing. This consolidation enables incremental extension of quality checks (formatting, additional linters, etc.) in a single location.
Changes:
- Added kube-linter configuration and Makefile targets for manifest/chart validation
- Created new GitHub Actions workflow for running code quality checks
- Parameterized helm-lint target branch for flexibility in CI
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Makefile | Added kube-linter version, installation target, and lint-manifests target; parameterized helm-lint with TARGET_BRANCH |
| .kube-linter.yaml | Configuration file excluding specific checks (resource requirements, selectors, security contexts) that may not apply to all manifests |
| .github/workflows/code-quality-check.yaml | New workflow running kube-linter and helm-lint on push/PR events with repository check |
53eedab to
001f801
Compare
|
hi @andreyvelich The GPU E2E failure appears unrelated to this PR. |
andreyvelich
left a comment
There was a problem hiding this comment.
Thanks for this @Goku2099!
I left a few comments, overall looks good.
|
hi @andreyvelich |
|
Can you check why CI is failing @Goku2099 ? |
|
@andreyvelich |
eb195b6 to
ef49b64
Compare
|
@andreyvelich With that fix in place, the Code Quality workflow should be fully green. |
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com> Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
e05828c to
53f35f9
Compare
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
53f35f9 to
d2c45a7
Compare
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
Introduces a consolidated Code Quality Checks workflow.
The intention is to consolidate quality-related CI checks in one place so we can extend it incrementally (helm lint, formatting, etc.) without scattering workflows.
Currently includes:
kube-linter checks for manifests and Helm charts
Follow-up PR: #3101