Skip to content

Reduce WebSocket flush wait from 100ms to 1ms #4461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 3 commits into from
Dec 12, 2025
+6 −2
Merged

Reduce WebSocket flush wait from 100ms to 1ms #4461

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af6a4be
Initial plan
Copilot Dec 10, 2025
2d7b94c
Reduce WebSocket flush delay from 100ms to 1ms
Copilot Dec 10, 2025
913b334
Use constants for flush timing values for better maintainability
Copilot Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions util/src/main/java/io/kubernetes/client/util/WebSocketStreamHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,10 @@ private class WebSocketOutputStream extends OutputStream {

private static final int WAIT_MILLIS = 10;

private static final int FLUSH_WAIT_MILLIS = 1;

private static final int MAX_FLUSH_ITERATIONS = MAX_WAIT_MILLIS / FLUSH_WAIT_MILLIS;

private final byte stream;

public WebSocketOutputStream(int stream) {
Expand Down Expand Up @@ -272,11 +276,11 @@ public void flush() throws IOException {
int i = 0;
while (WebSocketStreamHandler.this.socket.queueSize() > 0) {
try {
Thread.sleep(100);
Thread.sleep(FLUSH_WAIT_MILLIS);
} catch (InterruptedException ex) {
}
// Wait a maximum of 10 seconds.
if (i++ > 100) {
if (i++ > MAX_FLUSH_ITERATIONS) {
throw new IOException("Timed out waiting for web-socket to flush.");
}
}
Expand Down
Loading