WIP: Bump Kubernetes dependencies to v1.32 #240
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: petr-muller The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
sig/testing
petr-muller
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Updates k8s.io/* dependencies from v0.28.3 to v0.32.9 and related dependencies to maintain compatibility. Key dependency updates: - k8s.io/api: v0.28.3 → v0.32.9 - k8s.io/apimachinery: v0.28.3 → v0.32.9 - k8s.io/client-go: v0.28.3 → v0.32.9 - sigs.k8s.io/controller-runtime: v0.16.5 → v0.19.4 - sigs.k8s.io/prow: updated to latest - Go: 1.23.0 → 1.24.0 (required by prow) Breaking changes in controller-runtime v0.18.0 introduced generics support for Sources, Event Handlers, and Predicates. Updated code to use the new typed APIs: - Updated source.Kind() and source.Channel() to pass handlers and predicates as parameters instead of to ctrl.Watch() - Converted handlers to use TypedEventHandler with generic type parameters - Converted predicates to use TypedPredicate and TypedFuncs - Changed event channels from GenericEvent to TypedGenericEvent All tests pass with the updated dependencies. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
petr-muller
force-pushed
the
bump-k8s-deps-1.32
branch
from
6898c60 to
d53cd4a
Compare
|
/test pull-boskos-build-test-verify |
1 similar comment
|
/test pull-boskos-build-test-verify |
|
/retest |
|
/test pull-boskos-build-test-verify\ |
|
@petr-muller: The specified target(s) for Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-boskos-build-test-verify |
|
mmmmm something's not quite right, https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_boskos/240/pull-boskos-build-test-verify/2008175926596079616 is still hanging |
|
/test pull-boskos-build-test-verify (will take a closer look if it times out again and not a flake) |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Summary
Updates Kubernetes dependencies from v0.28.3 to v0.32.9 to support Kubernetes 1.32.
Changes
Dependency Updates
Code Changes
Controller-runtime v0.18.0 introduced breaking changes with generics support for Sources, Event Handlers, and Predicates. Updated the codebase to use the new typed APIs:
cleaner/v2/cleaner.go:
source.Kind()call to pass handler as parameter with typed genericscmd/boskos/boskos.go:
event.GenericEventtoevent.TypedGenericEvent[ctrlruntimeclient.Object]constHandler()to generic function returninghandler.TypedEventHandler[T, reconcile.Request]resourceUpdatePredicate()to usepredicate.TypedPredicate[*crds.ResourceObject]andpredicate.TypedFuncssource.Kind()andsource.Channel()calls to new API where handlers and predicates are passed as parametersTest plan
🤖 Generated with Claude Code