Implement regular polling for secrets#185
Implement regular polling for secrets#185stlaz wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stlaz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This issue is currently awaiting triage. If secrets-store-sync-controller contributors determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
===========================================
- Coverage 56.32% 41.39% -14.94%
===========================================
Files 12 12
Lines 1051 848 -203
===========================================
- Hits 592 351 -241
- Misses 415 466 +51
+ Partials 44 31 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...st_staging/charts/secrets-store-sync-controller/templates/secrets-store-sync-controller.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Oh I see you plan on adding tests in the other PR, that is fine.
manifest_staging/charts/secrets-store-sync-controller/README.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Stanislav Láznička <slznika@microsoft.com>
…ince 1.30) Signed-off-by: Stanislav Láznička <slznika@microsoft.com>
|
@stlaz: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes
Fixes #6
Special notes for your reviewer:
Tests will be added as a part of #178