Skip to content

Implement regular polling for secrets#185

Open
stlaz wants to merge 2 commits intokubernetes-sigs:mainfrom
stlaz:secrets-poll
Open

Implement regular polling for secrets#185
stlaz wants to merge 2 commits intokubernetes-sigs:mainfrom
stlaz:secrets-poll

Conversation

@stlaz
Copy link
Contributor

@stlaz stlaz commented Feb 10, 2026

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes
Fixes #6

Special notes for your reviewer:
Tests will be added as a part of #178

  • includes documentation

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 10, 2026
@k8s-ci-robot k8s-ci-robot requested a review from aramase February 10, 2026 11:05
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stlaz
Once this PR has been reviewed and has the lgtm label, please assign aramase for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from enj February 10, 2026 11:05
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 10, 2026
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If secrets-store-sync-controller contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 10, 2026
@stlaz stlaz changed the title Secrets poll Implement regular polling for secrets Feb 10, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.39%. Comparing base (9f4597d) to head (a058b76).
⚠️ Report is 78 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/secretsync_controller.go 0.00% 34 Missing ⚠️
cmd/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #185       +/-   ##
===========================================
- Coverage   56.32%   41.39%   -14.94%     
===========================================
  Files          12       12               
  Lines        1051      848      -203     
===========================================
- Hits          592      351      -241     
- Misses        415      466       +51     
+ Partials       44       31       -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@enj enj added this to SIG Auth Feb 10, 2026
@enj enj moved this to Subprojects - Needs Triage in SIG Auth Feb 10, 2026
Copy link

@enj enj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick pass.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration test?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see you plan on adding tests in the other PR, that is fine.

@github-project-automation github-project-automation bot moved this from Subprojects - Needs Triage to Changes Requested in SIG Auth Feb 11, 2026
Signed-off-by: Stanislav Láznička <slznika@microsoft.com>
…ince 1.30)

Signed-off-by: Stanislav Láznička <slznika@microsoft.com>
@k8s-ci-robot
Copy link
Contributor

@stlaz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-secrets-store-sync-controller-image-scan a058b76 link false /test pull-secrets-store-sync-controller-image-scan

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement secrets rotation

4 participants