Skip to content

Conversation

@kannon92
Copy link
Contributor

@kannon92 kannon92 commented Dec 7, 2025

  • One-line PR description: Fix typos in KEP and update with latest api
  • Other comments:

I was testing this feature for 1.35. I wanted to learn more about it.

I had to tweak the examples a bit to get this to work.

apiVersion: scheduling.k8s.io/v1alpha1   
kind: Workload
metadata:
  namespace: default
  name: job-1
spec:
  podGroups:
    - name: "pg1"
      policy:
        gang:
          minCount: 50

An example job:

apiVersion: batch/v1
kind: Job
metadata:
  name: sleep-job
spec:
  parallelism: 200
  completions: 200
  template:
    spec:
      workloadRef:
        name: job-1
        podGroup: pg1
      containers:
      - name: sleep-container
        image: busybox:latest
        command: ["sleep", "10000"]
        resources:
          requests:
            cpu: 100m
            memory: 100Mi
          limits:
            cpu: 100m
            memory: 100Mi
      restartPolicy: Never
  backoffLimit: 4

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Dec 7, 2025
@k8s-ci-robot k8s-ci-robot requested review from dom4ha and macsko December 7, 2025 20:14
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 7, 2025
@kannon92
Copy link
Contributor Author

kannon92 commented Dec 7, 2025

cc @wojtek-t @helayoty @erictune

@kannon92 kannon92 force-pushed the fix-typos-gang-scheduling branch from 4e04ba9 to d9ceb91 Compare December 7, 2025 20:15

[#5501]: https://github.com/kubernetes/enhancements/pull/5501

The example below shows how this could look like for with the following `Workload` object:
Copy link
Member

@macsko macsko Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the pod spec below as well:

apiVersion: v1
kind: Pod
metadata:
  name: jobset-job-1-abc123
spec:
  ...
  workloadKey:
    name: jobset
    podGroup: job-1
    podGroupReplicaKey: key-2
  ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: erictune, kannon92
Once this PR has been reviewed and has the lgtm label, please assign macsko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2025
@kannon92 kannon92 requested a review from macsko December 9, 2025 02:27
spec:
...
workload:
workloadKey:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be workloadRef

@kannon92 kannon92 requested a review from wojtek-t December 9, 2025 19:20
template:
spec:
workload:
workloadRef:
Copy link
Member

@macsko macsko Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also replace all spec.workload occurrences in the KEP to spec.workloadRef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants