-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[KEP-4671]: fix api version issue and update api with implementation #5725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
4e04ba9 to
d9ceb91
Compare
|
|
||
| [#5501]: https://github.com/kubernetes/enhancements/pull/5501 | ||
|
|
||
| The example below shows how this could look like for with the following `Workload` object: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the pod spec below as well:
apiVersion: v1
kind: Pod
metadata:
name: jobset-job-1-abc123
spec:
...
workloadKey:
name: jobset
podGroup: job-1
podGroupReplicaKey: key-2
...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: erictune, kannon92 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| spec: | ||
| ... | ||
| workload: | ||
| workloadKey: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be workloadRef
| template: | ||
| spec: | ||
| workload: | ||
| workloadRef: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also replace all spec.workload occurrences in the KEP to spec.workloadRef
I was testing this feature for 1.35. I wanted to learn more about it.
I had to tweak the examples a bit to get this to work.
An example job: