-
Notifications
You must be signed in to change notification settings - Fork 5.1k
kic: plumb ip-family and ipv6 for docker bridge #22063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kartikjoshi21 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @kartikjoshi21. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Logs: |
|
Can one of the admins verify this patch? |
1939182 to
51d0069
Compare
|
Testing Steps : |
51d0069 to
792dee2
Compare
This PR teaches the Docker (KIC) driver about
ip-familyand IPv6/dual-stack, building on the config/flag plumbing from PR1. It does not yet change kubeadm/CNI templates; those are follow-ups.Concretely, it:
Plumbs
IPFamily,StaticIPv6, andSubnetv6fromClusterConfiginto the KIC driver andCreateContainerNode, so nodes can get static IPv4/IPv6 addresses.Replaces
CreateNetworkwithCreateNetworkWithIPFamilyto create:--ipv6, IPv4 + optional--subnet-v6), and--ipv6, optional v6 subnet),and requires
--subnet-v6when--static-ipv6is used instead of guessing a /64.Assigns container IPs per family and updates
GetIP,GetExternalIP, andGetSSHHostnameso:::1(or::for external Docker),Extends Docker network inspect/gateway helpers and
digDNSto understand dual-stack networks:Updates container run args and port publishing:
--ip6when a static IPv6 is configured and enables IPv4/IPv6 forwarding + bridge netfilter sysctls for IPv6/dual clusters.--publishflags (e.g.[::1]::8443).Generalises
ServiceClusterIPandDNSIPso they work for both IPv4 and IPv6 service CIDRs by incrementing the base IP generically instead of assuming IPv4.For
--ip-family=ipv4with no IPv6 flags, behaviour stays the same as today.Fixes: #8535
Refer to this for testing steps: #22063 (comment)
Tested and verified on: