Skip to content

Conversation

@skitt
Copy link
Member

@skitt skitt commented Sep 18, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This replaces strings/slices functions that have equivalents in Go’s slices package with calls to the latter.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skitt
Once this PR has been reviewed and has the lgtm label, please assign dims for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 18, 2025
@skitt
Copy link
Member Author

skitt commented Sep 18, 2025

Ah we’re still on Go 1.18.

@skitt skitt closed this Sep 18, 2025
@liggitt
Copy link
Member

liggitt commented Sep 18, 2025

we can update the go version to the minimum go version required by the oldest supported kubernetes branch (currently 1.31, https://kubernetes.io/releases/#release-history, so go 1.22 - https://github.com/kubernetes/kubernetes/blob/release-1.31/go.mod)

once that includes the stdlib slices package, we can do this

@skitt
Copy link
Member Author

skitt commented Sep 18, 2025

once that includes the stdlib slices package, we can do this

Right, so once 1.31 reaches EOL at the end of October and we can bump to 1.23: https://github.com/kubernetes/kubernetes/blob/release-1.32/go.mod

@skitt
Copy link
Member Author

skitt commented Sep 18, 2025

Actually Go 1.21 has everything this needs…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants