Skip to content

Comments

fix Test_07 after CRD change#713

Merged
matthyx merged 2 commits intomainfrom
test07
Feb 10, 2026
Merged

fix Test_07 after CRD change#713
matthyx merged 2 commits intomainfrom
test07

Conversation

@matthyx
Copy link
Contributor

@matthyx matthyx commented Feb 5, 2026

Summary by CodeRabbit

  • Tests

    • Improved test error diagnostics with captured stderr output for clearer failure messages.
    • Adjusted component tests to disable client-side schema validation during YAML apply operations.
  • Chores

    • Updated CI tooling downloads and installation sources to more recent, platform-appropriate releases.

@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Test infra updates: capture and log command stderr on failures; bump CI tooling download targets (kind v0.31.0, kubectl via dl.k8s.io); and disable client-side validation for four kubectl apply calls in a component test.

Changes

Cohort / File(s) Summary
Command Error Handling
tests/testutils/utils.go
Replaced cmd.Stderr = io.Discard with a bytes.Buffer to capture stderr, added imports bytes and fmt, and conditionally print Command 'name args' failed: <stderr> when exec.ExitError contains stderr; retains returning the exit code.
CI Tooling Updates
.github/workflows/component-tests.yaml
Updated Kind download target to v0.31.0 (platform filename adjusted) and switched kubectl download URL to the Kubernetes stable API (dl.k8s.io) for v1.35.0.
Test Configuration
tests/component_test.go
Added --validate=false to four kubectl apply invocations in Test_07_RuleBindingApplyTest to disable client-side schema validation for those YAML files.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 I poked my nose into stderr's den,

Captured whispers from a troubled when.
Kind leapt forward, kubectl in tow,
Validation paused — let the tests flow.
Hooray, the CI burrows glow! 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix Test_07 after CRD change' accurately reflects the main changes: updates to Test_07_RuleBindingApplyTest and supporting fixes after a CRD schema change.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch test07

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx matthyx force-pushed the test07 branch 2 times, most recently from 43a96f5 to 377488d Compare February 10, 2026 18:14
…on for rule binding applies

Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx matthyx changed the title update Test_07 expectations after CRD change fix Test_07 after CRD change Feb 10, 2026
@matthyx matthyx merged commit 21d230a into main Feb 10, 2026
27 checks passed
@matthyx matthyx deleted the test07 branch February 10, 2026 19:45
@matthyx matthyx moved this from WIP to To Archive in KS PRs tracking Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Archive

Development

Successfully merging this pull request may close these issues.

1 participant