📖docs: updated community meetings link in README#929
📖docs: updated community meetings link in README#929Janhvibabani wants to merge 2 commits intokubestellar:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome to KubeStellar! 🚀 Thank you for submitting this Pull Request. Before your PR can be merged, please ensure: ✅ DCO Sign-off - All commits must be signed off with ✅ PR Title - Must start with an emoji: ✨ (feature), 🐛 (bug fix), 📖 (docs), 🌱 (infra/tests), Getting Started with KubeStellar: Contributor Resources:
🌟 Help KubeStellar Grow - We Need Adopters! Our roadmap is driven entirely by adopter feedback. Whether you're using KubeStellar yourself or know someone who could benefit from multi-cluster Kubernetes: 📋 Take our Multi-Cluster Survey - Share your use cases and help shape our direction! A maintainer will review your PR soon. Feel free to ask questions in the comments or on Slack! |
|
Hi @Janhvibabani. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubestellar-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Updates the README’s “Community Meetings” link to avoid directing users to an outdated (2023) Google Calendar event.
Changes:
- Replaced the “community calendar” hyperlink under Community Meetings in
README.md.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
README.md
Outdated
| - [kubestellar-dev](https://groups.google.com/g/kubestellar-dev) — Development discussions | ||
| - [kubestellar-users](https://groups.google.com/g/kubestellar-users) — User community discussions | ||
| - **Community Meetings**: Subscribe to our [community calendar](https://calendar.google.com/calendar/event?action=TEMPLATE&tmeid=MWM4a2loZDZrOWwzZWQzZ29xanZwa3NuMWdfMjAyMzA1MThUMTQwMDAwWiBiM2Q2NWM5MmJlZDdhOTg4NGVmN2ZlOWUzZjZjOGZlZDE2ZjZmYjJmODExZjU3NTBmNTQ3NTY3YTVkZDU4ZmVkQGc&tmsrc=b3d65c92bed7a9884ef7fe9e3f6c8fed16f6fb2f811f5750f547567a5dd58fed%40group.calendar.google.com&scp=ALL) | ||
| - **Community Meetings**: Subscribe to our [community calendar](https://docs.google.com/document/d/1XppfxSOD7AOX1lVVVIPWjpFkrxakfBfVzcybRg17-PM/edit?tab=t.0#heading=h.x7eowycdcihh) |
There was a problem hiding this comment.
The link text says “Subscribe to our community calendar”, but the new URL points to a Google Doc (meeting agenda) rather than a calendar subscription/view link. This doesn’t match the stated goal of replacing the date-specific calendar event link with a non–date-specific calendar link, and it may also be inaccessible to users without doc permissions. Consider updating the URL to the project’s non–date-specific calendar subscription/view link (e.g., the public .ics or embed link used in docs/content/Community/_index.md) or adjust the link text to reflect that it’s an agenda document instead of a calendar.
|
@Janhvibabani ,the Copilot suggestions look good. Please go ahead and implement them. |
Signed-off-by: JANHVI BABANI <114232474+Janhvibabani@users.noreply.github.com>
…of a calendar. Signed-off-by: JANHVI BABANI <114232474+Janhvibabani@users.noreply.github.com>
40d2577 to
d8e242c
Compare
|
@oksaumya updated it, check! |
|
still asking permission |
KPRoche
left a comment
There was a problem hiding this comment.
I believe the agenda is only accessible via that link after one has successfully joined the mailing list. I think it would be wise to move its position in the list and note that fact.
That is also how you get the meeting notifications.
|
hey, @KPRoche are you taking it over? i was actually unaware that we couldn't see the link unless we are part of the mailing list thanks for making it clear, i will add a note and make the changes if you haven't started working on it yet. |
Technically I never left :-) I double-checked, and the meeting link is sent out to all members of the mailing list (and slack channel), so those are the best route to ensuring people get the most current link. |
|
@KPRoche Wow I didn't know this,just want to confirm I’ve got this right, Would adding an instruction to join the mailing list for the latest meeting updates be enough, and remove the link which leads to 2023 calendar event? |
📌 Fixes
Fixes #866
📝 Summary of Changes
The previous link used to point to https://calendar.google.com/calendar/event?action=TEMPLATE&tmeid=MWM4a2loZDZrOWwzZWQzZ29xanZwa3NuMWdfMjAyMzA1MThUMTQwMDAwWiBiM2Q2NWM5MmJlZDdhOTg4NGVmN2ZlOWUzZjZjOGZlZDE2ZjZmYjJmODExZjU3NTBmNTQ3NTY3YTVkZDU4ZmVkQGc&tmsrc=b3d65c92bed7a9884ef7fe9e3f6c8fed16f6fb2f811f5750f547567a5dd58fed%40group.calendar.google.com&scp=ALL which was a wrong link as it used to point the meeting from 2023
Changes Made
Checklist
Please ensure the following before submitting your PR:
Screenshots or Logs (if applicable)
👀 Reviewer Notes
Add any special notes for the reviewer here