Skip to content

Removed workspace.name #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Kareem-dev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed workspace.name #69

Kareem-dev wants to merge 1 commit into from

Conversation

@Kareem-dev
Copy link

@Kareem-dev Kareem-dev commented Jun 12, 2021 •
edited
Loading

I personally didn't like having the workspace name in the snap, you don't have to accept it however I would prefer if there was an option to remove it

@Kareem-dev
Removed workspace name
98347f9 
I personally didn't like having the workspace name in the snap, you don't have to accept the changes, but I would be prefer if you add this as an option in the next update.
NatoBoram
NatoBoram suggested changes Mar 9, 2022
View reviewed changes
Copy link

@NatoBoram NatoBoram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably add the option instead of just removing the feature. There's a PR that adds an option, you could use that:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NatoBoram NatoBoram NatoBoram requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kareem-dev @NatoBoram