Fix undefined pthread_ references on glibc < 2.34 #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Building tools/rvsim with mini-gdbstub enabled can fail on systems with glibc < 2.34 due to missing pthread symbols such as
pthread_create/pthread_join.Because
libgdbstub.auses pthread APIs, but rvsim’s link flags do not include pthread, causing the final link step to fail.On glibc >= 2.34, this issue may not trigger a link error because glibc merged libpthread functionality into libc
Change
Add pthread to the link flags in tools/Makefile:
Note
This change is required on glibc < 2.34 where pthread symbols are not provided by libc by default.
On glibc >= 2.34,
-lpthreadremains safe because glibc keeps the linker option working for backwards compatibility (empty libpthread.a is provided), so this should not affect newer systems.