Conversation
|
Ready 🫡 |
Deploying karriba with
|
| Latest commit: |
c9b2a44
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7a2cafbd.karriba.pages.dev |
| Branch Preview URL: | https://93-filter-by-date.karriba.pages.dev |
app/lib/record/records_page.dart
Outdated
| ); | ||
| } | ||
|
|
||
| Widget _buildFilterSheet() { |
There was a problem hiding this comment.
I think we should move this to a separate RecordsFilterBottomSheet widget.
I've noticed a bug where when I select a date range, the bottom sheet still shows the previously selected date range. It doesn't update the displayed date range until I apply the date range and re-open the bottom sheet.
I think moving to a separate widget might help with this, because the setState might apply correctly.
Also, it is recommended to use widgets rather than helper methods for things like this because it improves performance - https://www.youtube.com/watch?v=IOyq-eTRhvo
There was a problem hiding this comment.
Moved and fixed 😄 I also added a little message when no records are found to show "No records found." on the center of the page.
Closes #93
Changes
queryAllRowsin Records DAO.Testing