Skip to content

Get rid of "disabled" on fields in BasicSettings. #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylev merged 1 commit into from
Aug 12, 2025
Merged

Get rid of "disabled" on fields in BasicSettings. #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/BasicSettings.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ function BasicSettings({ hidden, role, store }) {
label={t("guideangle")}
type="number"
value={store.guideline.angle}
disabled={store.ratio !== "custom"}
onChange={(e) => store.setGuidelineAngle(e.target.value)}
Copy link
Owner Author

@kylev kylev Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This suggestion is also already handled by the store implementation!

Looking at the store code (SHA 1074b77), store.setGuidelineAngle() already automatically switches to "custom" when called:

setGuidelineAngle(angle) {
  this.guideline.angle = Math.min(Math.max(angle, 15), 90);
  if (this.ratio !== "custom") this.setRatioPreset("custom");
}

The current implementation onChange={(e) => store.setGuidelineAngle(e.target.value)} is correct and complete. The store method handles both updating the angle value AND switching to custom preset automatically.

slotProps={{
input: {
Expand Down
1 change: 0 additions & 1 deletion src/RatiosInput.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ function RatiosInput({ store }) {
<Input
type="number"
value={r}
disabled={store.ratio !== "custom"}
onChange={(e) => store.setRatio(i, e.target.value)}
Copy link
Owner Author

@kylev kylev Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This suggestion is already handled by the store implementation!

Looking at the store code (SHA 1074b77), store.setRatio() already automatically switches to "custom" when called:

setRatio(index, value) {
  this.ratios[index] = Math.min(Math.max(value, 0), 20);
  if (this.ratio !== "custom") this.setRatioPreset("custom");
}

So the current implementation onChange={(e) => store.setRatio(i, e.target.value)} is correct and doesn't need the additional setPreset('custom') call.

style={{ marginTop: 16, width: 60 }}
/>
Expand Down