Skip to content

haxeget install latest, and install haxe from github releases using octocrab#14

Draft
ninjamuffin99 wants to merge 1 commit intol0go:mainfrom
ninjamuffin99:latest-gh-release
Draft

haxeget install latest, and install haxe from github releases using octocrab#14
ninjamuffin99 wants to merge 1 commit intol0go:mainfrom
ninjamuffin99:latest-gh-release

Conversation

@ninjamuffin99
Copy link
Contributor

@ninjamuffin99 ninjamuffin99 commented Mar 28, 2024

"latest" will lead to the latest release uploaded to github releases
ex: github.com/HaxeFoundation/haxe/releases/latest will link to the 4.3.4 tag/release.

octocrab is a crate I added since I'm too lazy to write up the API schema stuff... lol!

Using octocrab, we can make a nice and easy call to get the latest github haxe release, and nice and easily download it by passing in latest to haxeget install

todo

  • when inputting latest, make sure it gets logged as whatever the version downloaded was into the cache (haxeget list will show latest rather than 4.3.4)

@ninjamuffin99 ninjamuffin99 marked this pull request as draft March 28, 2024 21:48
@l0go
Copy link
Owner

l0go commented Mar 29, 2024

Real neat! Please alert me once this is suitable to be merged. Do we need octocrab? Pretty sure I have everything exposed already?

@ninjamuffin99
Copy link
Contributor Author

very likely don't need octocrab! I was just lazy lolol, i will poke into the github_schema and use those api bindings

I do think though it makes it nicer to not have to do any json / http request parsing/setup for github api, food for thought :)

@l0go
Copy link
Owner

l0go commented Mar 29, 2024

very likely don't need octocrab! I was just lazy lolol, i will poke into the github_schema and use those api bindings

I do think though it makes it nicer to not have to do any json / http request parsing/setup for github api, food for thought :)

Do whatever you think will be best, I'll leave the judgement up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants