4.14.4 test feature #6073
Closed
4.14.4 test feature #6073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: publish channel doc link * fix: checkbox disable hover style * fix: huggingface.svg missing; update doc * chore: update doc * fix: typo
* fix: export log dateend * feat: file selector render
Contributor
|
There is too much information in the pull request to test. |
Preview sandbox Image: |
Preview mcp_server Image: |
Docs Preview:🚀 FastGPT Document Preview Ready! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements version 4.14.4 development changes, focusing on S3 infrastructure refactoring, improved null safety, and i18n standardization.
Key Changes:
- Refactored S3 source classes to use inheritance instead of composition, consolidating common methods in
S3BaseBucket - Renamed S3 methods from
getObjecttogetFileStreamand standardized metadata retrieval with null safety - Standardized locale handling by removing locale parameters from API calls and using centralized
getLocale()function - Added file input support for workflow tools with new
FileSelectcomponent
Reviewed changes
Copilot reviewed 52 out of 56 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| test/mocks/common/s3.ts | Updated mock methods to match refactored S3 API (getObject → getFileStream) |
| projects/app/src/pages/api/system/file/[jwt].ts | Added null check for metadata before setting response headers |
| projects/app/src/pages/api/core/dataset/data/v2/list.ts | Added null check for S3 file metadata before accessing properties |
| projects/app/src/pages/api/core/app/getChatLogs.ts | Removed locale parameter, now using centralized getLocale() function |
| projects/app/src/pages/api/core/app/exportChatLogs.ts | Standardized locale retrieval using getLocale() instead of parameter |
| projects/app/src/pages/api/common/file/read/[filename].ts | Updated to use renamed getFileStream method |
| projects/app/src/pages/account/customDomain/index.tsx | Added type property to delete confirmation modal |
| projects/app/src/pageComponents/app/detail/WorkflowComponents/Flow/nodes/render/RenderInput/templates/FileSelect.tsx | New component for file URL input in workflows |
| projects/app/src/pageComponents/app/detail/WorkflowComponents/Flow/nodes/render/RenderInput/index.tsx | Updated to use FileSelect component instead of Reference |
| projects/app/src/pageComponents/app/detail/Publish/OffiAccount/*.tsx | Simplified documentation links by removing conditional fallback logic |
| projects/app/src/pageComponents/app/detail/Publish/FeiShu/*.tsx | Simplified documentation links |
| projects/app/src/pageComponents/app/detail/Publish/DingTalk/*.tsx | Simplified documentation links |
| projects/app/src/pageComponents/app/detail/Logs/LogTable.tsx | Removed locale parameter from API calls and translation file references |
| projects/app/src/global/core/api/appReq.d.ts | Removed locale property from GetAppChatLogsProps type |
| projects/app/src/components/core/chat/components/WholeResponseModal.tsx | Split plugin output into separate tool input and output rows |
| projects/app/src/components/core/app/FileSelector/index.tsx | Added safe translation hook and error message translation |
| projects/app/public/imgs/modal/huggingface.svg | Added missing HuggingFace icon SVG file |
| packages/web/styles/theme.ts | Enhanced checkbox disabled state styling to prevent hover effects |
| packages/web/i18n/*/common.json | Removed obsolete "plugin output" translation key |
| packages/web/i18n/*/chat.json | Added tool_input/tool_output translations and reordered entries |
| packages/web/i18n/*/app.json | Added export_log_filename translation with template variable |
| packages/web/components/core/workflow/NodeInputSelect.tsx | Added fileSelect input type option and cleaned up formatting |
| packages/service/support/permission/auth/file.ts | Changed file existence check from getDatasetFileStat to isObjectExists |
| packages/service/core/workflow/dispatch/tools/readFiles.ts | Refactored to use S3RawTextSource instead of S3DatasetSource for raw text buffer |
| packages/service/core/workflow/dispatch/plugin/*.ts | Added toolInput to response objects for better debugging |
| packages/service/core/workflow/dispatch/child/runTool.ts | Added toolInput tracking across all tool execution paths |
| packages/service/core/dataset/controller.ts | Added batched deletion with timeout controls for dataset cleanup |
| packages/service/core/dataset/apiDataset/custom/api.ts | Updated to use S3RawTextSource for raw text operations |
| packages/service/common/s3/sources/rawText/*.ts | New dedicated source class for raw text buffer operations |
| packages/service/common/s3/sources/dataset/*.ts | Refactored to extend S3PrivateBucket and delegate raw text operations |
| packages/service/common/s3/sources/chat/index.ts | Refactored to extend S3PrivateBucket, removing duplicate methods |
| packages/service/common/s3/sources/avatar.ts | Refactored to extend S3PublicBucket |
| packages/service/common/s3/buckets/*.ts | Added getFileMetadata, renamed methods, improved error handling |
| packages/service/common/geo/index.ts | Updated to use standardized localeType and formatting function |
| packages/global/core/workflow/runtime/type.d.ts | Removed duplicate pluginOutput property, added toolInput |
| packages/global/common/i18n/utils.ts | Added formatI18nLocationToZhEn utility function |
| document/* | Updated documentation with spelling corrections and timestamp updates |
Comments suppressed due to low confidence (5)
projects/app/src/pageComponents/app/detail/WorkflowComponents/Flow/nodes/render/RenderInput/templates/FileSelect.tsx:5
- Unused import Avatar.
projects/app/src/pageComponents/app/detail/WorkflowComponents/Flow/nodes/render/RenderInput/templates/FileSelect.tsx:6 - Unused import SelectAppModal.
projects/app/src/pageComponents/app/detail/WorkflowComponents/Flow/nodes/render/RenderInput/templates/FileSelect.tsx:9 - Unused import useRequest2.
projects/app/src/pageComponents/app/detail/WorkflowComponents/Flow/nodes/render/RenderInput/templates/FileSelect.tsx:10 - Unused import getAppDetailById.
projects/app/src/pageComponents/app/detail/WorkflowComponents/Flow/nodes/render/RenderInput/templates/FileSelect.tsx:12 - Unused import AppContext.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| if (!RenderItem) return null; | ||
|
|
||
| console.log(renderType, input); |
There was a problem hiding this comment.
Debug console.log statement should be removed before merging to production. This appears to be leftover debugging code.
| "start_chat": "Start", | ||
| "stream_output": "Stream Output", | ||
| "task_has_continued": "Task has continued running", | ||
| "tool_input": "tool input", |
There was a problem hiding this comment.
The traditional Chinese translation has inconsistent capitalization for "tool input". It should be "工具輸入" (with capital case consistency matching "tool_output" on line 171 which shows "工具輸出").
Suggested change
| "tool_input": "tool input", | |
| "tool_input": "Tool input", |
Comment on lines
+99
to
+116
| // Delete dataset_data_texts in batches by datasetId | ||
| for (const datasetId of datasetIds) { | ||
| await MongoDatasetDataText.deleteMany({ | ||
| teamId, | ||
| datasetId | ||
| }).maxTimeMS(300000); // Reduce timeout for single batch | ||
| } | ||
| // Delete dataset_datas in batches by datasetId | ||
| for (const datasetId of datasetIds) { | ||
| await MongoDatasetData.deleteMany({ | ||
| teamId, | ||
| datasetId | ||
| }).maxTimeMS(300000); | ||
| } | ||
|
|
||
| await delCollectionRelatedSource({ collections }); | ||
| // Delete vector data | ||
| await deleteDatasetDataVector({ teamId, datasetIds }); |
There was a problem hiding this comment.
Duplicate deletion logic detected. Lines 99-116 appear to be duplicated from lines 118-135. The first block (99-116) deletes dataset_data_texts and dataset_datas, then calls delCollectionRelatedSource and deleteDatasetDataVector. However, lines 118-120 then attempt to delete dataset_data_texts again. This duplication is unnecessary and could cause performance issues.
Comment on lines
+4
to
+18
| import type { SelectAppItemType } from '@fastgpt/global/core/workflow/template/system/abandoned/runApp/type'; | ||
| import Avatar from '@fastgpt/web/components/common/Avatar'; | ||
| import SelectAppModal from '../../../../SelectAppModal'; | ||
| import { useTranslation } from 'next-i18next'; | ||
| import { useContextSelector } from 'use-context-selector'; | ||
| import { useRequest2 } from '@fastgpt/web/hooks/useRequest'; | ||
| import { getAppDetailById } from '@/web/core/app/api'; | ||
| import { WorkflowActionsContext } from '@/pageComponents/app/detail/WorkflowComponents/context/workflowActionsContext'; | ||
| import { AppContext } from '@/pageComponents/app/detail/context'; | ||
| import MyIcon from '@fastgpt/web/components/common/Icon'; | ||
| import MyDivider from '@fastgpt/web/components/common/MyDivider'; | ||
| import { getFileIcon } from '@fastgpt/global/common/file/icon'; | ||
| import MyAvatar from '@fastgpt/web/components/common/Avatar'; | ||
| import IconButton from '@/pageComponents/account/team/OrgManage/IconButton'; | ||
| import MyIconButton from '@fastgpt/web/components/common/Icon/button'; |
There was a problem hiding this comment.
Unused imports should be removed:
SelectAppItemType(line 4) - type not usedAvatar(line 5) - imported butMyAvatar(line 16) is used insteadSelectAppModal(line 6) - component not useduseRequest2(line 9) - hook not usedgetAppDetailById(line 10) - API function not usedAppContext(line 12) - context not usedIconButton(line 17) - component not used,MyIconButton(line 18) is used instead
Only remove the actually unused ones to keep imports clean.
| 1. ### 当前分组上游负载已饱和，请稍后再试(request id:202407100753411462086782835521) | ||
|
|
||
| 是oneapi渠道的问题，可以换个模型用or换一家中转站 | ||
| 是oneapi渠道的问题，可以换个模型用或者换一家中转站 |
There was a problem hiding this comment.
[nitpick] Missing space in Chinese text. The phrase "换个模型用或者换一家中转站" should have a space or punctuation between "用" and "或者" for better readability. Consider: "换个模型用，或者换一家中转站"
Suggested change
| 是oneapi渠道的问题，可以换个模型用或者换一家中转站 | |
| 是oneapi渠道的问题，可以换个模型用，或者换一家中转站 |
| feConfigs.openAPIDocUrl || | ||
| getDocPath('/docs/use-cases/external-integration/official_account/') | ||
| } | ||
| href={getDocPath('/docs/use-cases/external-integration/official_account')} |
There was a problem hiding this comment.
Inconsistent URL path: Line 78 uses /docs/use-cases/external-integration/official_account without a trailing slash, while line 99 in OffiAccountEditModal.tsx uses /docs/use-cases/external-integration/official_account/ with a trailing slash. URLs should be consistent across the codebase.
| feConfigs.openAPIDocUrl || | ||
| getDocPath('/docs/use-cases/external-integration/feishu/') | ||
| } | ||
| href={getDocPath('/docs/use-cases/external-integration/feishu')} |
There was a problem hiding this comment.
Inconsistent URL paths for FeiShu documentation. The index file uses /docs/use-cases/external-integration/feishu (no trailing slash) while FeiShuEditModal.tsx line 93 uses /docs/use-cases/external-integration/feishu/ (with trailing slash). These should be consistent.
| @@ -0,0 +1,127 @@ | |||
| import React, { useCallback, useMemo, useState } from 'react'; | |||
| import type { RenderInputProps } from '../type'; | |||
| import { Box, Button, HStack, Input, InputGroup, useDisclosure, VStack } from '@chakra-ui/react'; | |||
There was a problem hiding this comment.
Unused imports Button, useDisclosure.
| import MyDivider from '@fastgpt/web/components/common/MyDivider'; | ||
| import { getFileIcon } from '@fastgpt/global/common/file/icon'; | ||
| import MyAvatar from '@fastgpt/web/components/common/Avatar'; | ||
| import IconButton from '@/pageComponents/account/team/OrgManage/IconButton'; |
There was a problem hiding this comment.
Unused import IconButton.
| import MyAvatar from '@fastgpt/web/components/common/Avatar'; | ||
| import IconButton from '@/pageComponents/account/team/OrgManage/IconButton'; | ||
| import MyIconButton from '@fastgpt/web/components/common/Icon/button'; | ||
| import MyTooltip from '@fastgpt/web/components/common/MyTooltip'; |
There was a problem hiding this comment.
Unused import MyTooltip.
* team qpm limit & plan tracks * api entry qpm * perf: computed days * Revert "api entry qpm" This reverts commit 1210c07. * perf: code * system qpm limit * system qpm limit --------- Co-authored-by: archer <545436317@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.