Skip to content

Fix puget printer future handler #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
onbreath wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix puget printer future handler #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36b89a6
Fix puget printer future-handler not checking future value
onbreath Dec 1, 2025
1f96952
Add changelog entry for fix in puget printer for futures
onbreath Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

## Fixed

- Fixed puget printer for futures

## Changed

# 2.12.219 (2025-02-06 / 9e6942a)
Expand Down
2 changes: 1 addition & 1 deletion src/lambdaisland/deep_diff2/puget/printer.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@
java.util.concurrent.Future
(fn future-handler
[printer value]
(let [doc (if (future-done? promise)
(let [doc (if (future-done? value)
(format-doc printer @value)
(color/document printer :nil "pending"))]
(format-unknown printer value "Future" doc)))
Expand Down