Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like this has been a bit stuck, so hopefully this helps move things along.
I don't know if this is the right approach, so feedback is very welcome. At the very least this gets a working build on the al2023 image, building on what @philvarner did in #89.
I don't know if supporting the old al2 images is desirable, but figured they might still be useful, so for the time being this makes the al2023 images alongside them.
I've summarised what I've done, and what I think is left to do, but these might change, as at the moment this leaves the project supporting multiple gdal versions, which I think is a break from how you've done things.
Happy to make changes, or for someone to take what I've done here and repurpose it if it's useful.
Also if there's other QA I can do, that I haven't thought of, then let me know.
What I've done so far:
dockerfiles/Dockerfile.al2023and parametrise the build script./scripts/build.sh 3.11.5 python 3.13 al2023and fix things till it built, and tests (docker run --rm --entrypoint bash -v $(pwd):/local ghcr.io/lambgeo/lambda-gdal:3.11-al2023 /local/tests/tests.sh) passedStill ToDo:
scripts/deploy.pyfor AL2023 supportscripts/list.py