Issue 298 clang tidy false positives #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed const to const ref in validator/uuid removed more linter warnings and errors fixed more linting errors linting fixes and pinned clang-tidy 13 in ci.yml fixed more liting errors fixed most warnings/errors except magic numbers and closure fixed linting errors in RpcClient.cpp fixed all errors, only warnings remainings test pipeline fixed all errors during build fixed signature mismatch in header file save builds and all tests pass replaced some magic numbers fixed magic numbers in uuid.cpp replaced all magic numbers modified PendingRequest in RpcClient.cpp with public constructor deleted unsued code removed unused setters
…k, need to keep UTransportMock.h
|
Code coverage report is ready! 📈
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.