[Refactor] v2 update | v2版本重构升级 #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a v2 refactor that introduces a new download manager for handling video metadata retrieval and downloads, updates project configurations, and adds documentation and guidelines for development.
- Introduces DownloadManager in src/download.py with methods for fetching metadata and downloading videos.
- Updates project configuration via src/config.py, pyproject.toml, and restructures the main execution flow in main.py.
- Provides legacy utility functions and documentation updates in the archive folder, README.md, DEVELOPE.md, and CONTRIBUTING.md.
Reviewed Changes
Copilot reviewed 32 out of 34 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/download.py | New download manager class implementing video metadata and download functionality. |
| src/core.py | Basic module that imports global configurations. |
| src/config.py | New configuration settings for directories, tools, and service details. |
| pyproject.toml | Updated project configuration with dependency definitions. |
| main.py | Main entry point now invokes a self-check procedure. |
| archive/utils.py | Legacy utility for video download using you-get with a potential return value bug. |
| archive/main.py | Legacy test script for the old download and analysis workflow. |
| README.md | Updated logo path and simplified project description for v2. |
| DEVELOPE.md | New development guide documentation. |
| CONTRIBUTING.md | New contributing guidelines with submission and quality requirements. |
Files not reviewed (2)
- .python-version: Language not supported
- config.cfg: Language not supported
| except Exception as e: | ||
| print("发生错误:", str(e)) | ||
| file_path = "" | ||
| return bv_number |
There was a problem hiding this comment.
The download_video function's docstring indicates it should return the file path, but it returns 'bv_number' instead. Update the return statement to 'return file_path' to ensure correct behavior.
Suggested change
| return bv_number | |
| return file_path |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
还在构建中