feat(deepagents): support direct skill paths as sources in createSkillsMiddleware#242
Open
Alexei Vedernikov (alvedder) wants to merge 1 commit intolangchain-ai:mainfrom
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, sources had to be parent directories (e.g.
/skills/) whose subdirectories each contained a SKILL.md. Passing a direct skill path (e.g./skills/my-skill/) had no effect becauselistSkillsFromBackendscanned for subdirectories inside the source, found none, and returned an empty list.Real case
The motivating scenario is when a curated list of skills organised as individual directories under a shared directory. Each skill has a clear responsibility, and different skills are intentionally assigned to the orchestrator agent vs. subagents:
The workaround would be to create nested directories like this:
What's done
Detection is done by inspecting the lsInfo() result of the source directory: if a SKILL.md file appears directly in the listing, the source itself is treated as the skill directory. Otherwise the existing parent-directory scan runs unchanged.
The two modes can be freely mixed in the sources array: