fix: adjust JWT issued-at time to handle clock skew in local environment #745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies JWT generation for GitHub App authentication to account for potential clock skew between the local machine and GitHub's servers.
Changes:
Rationale:
In local development, JWT authentication was failing when the local machine’s clock was slightly ahead of GitHub's. This caused the GitHub API to reject the token as invalid. By subtracting 60 seconds from the iat value, we ensure reliable authentication without compromising security.
This adjustment follows the recommendation in GitHub’s official documentation on generating JWTs for a GitHub App, which uses the same offset to prevent clock-skew-related authentication failures. The example code provided in GitHub’s documentation, written in Ruby, demonstrates this approach.
References:
Fixes #744