refactor: extract keymap methods into separate files#45
Open
michaelgmcd wants to merge 1 commit intolaobubu:masterfrom
Open
refactor: extract keymap methods into separate files#45michaelgmcd wants to merge 1 commit intolaobubu:masterfrom
michaelgmcd wants to merge 1 commit intolaobubu:masterfrom
Conversation
Owner
|
Thanks for your efforts! I was planning to separate the functions into files, and provide them as "CodeMirror Commands". Your pull request will be very helpful! I Will test and merge in few days. |
ryooo
pushed a commit
to ryooo/HyperMD
that referenced
this pull request
Nov 20, 2020
fix: Disabled typographer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to look into #43, but the keymap file is pretty difficult to follow. Its size has a lot to do with it. There is definitely some more work that could be done (the tab file is pretty massive), but this is a start!