Blade Props #554
Open
Blade Props #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@TitasGailius Great work! #366 can be closed as well, because it requires parsed props attributes. |
Collaborator
Author
|
@N1ebieski You're totally right! That's a great point, but I'd really love to find a slightly more elegant solution for parsing the I think the best move is likely extending https://github.com/laravel/vs-code-php-parser-cli/ to support this parsing, rather than adding that logic directly into the templates here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes a different approach than #367. Instead of parsing the @props directive and relying on external libraries or extensions, we simply extract the code block and display it on hover.
This results in better looking hover cards that cover complicated cases, all with a much simpler implementation.
Unrelated: This PR also fixes an issue where sometimes duplicate paths were being shown.