-
Notifications
You must be signed in to change notification settings - Fork 54
chore: Update sdk_metadata features. #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
…, storingData sub-features) Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
…able Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
| "introduced": "8.4" | ||
| }, | ||
| "inlineContextFeatureEvents": { | ||
| "introduced": "8.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double check that this is accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified this in the CHANGELOG. There are actually two different inline context features:
- 8.3.0: "Inline contexts for all evaluation events" - This is
inlineContextFeatureEvents(inlining contexts in feature/evaluation events) - 8.9.0: "Inline context for custom and migration op events" - This is for custom events (different feature)
The sdk-meta feature inlineContextFeatureEvents has description "The SDK will inline the context inside feature events" which matches the 8.3.0 feature. The documentation row "Inline contexts in custom events" (8.9) refers to custom events, which is a different capability.
So 8.3 is correct for inlineContextFeatureEvents.
.sdk_metadata.json
Outdated
| "introduced": "2.0.1" | ||
| }, | ||
| "storingData": { | ||
| "introduced": "2.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like its missing a minor version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Updated storingData from "2.3" to "2.3.1" to match the documentation which shows "2.3.1 (Redis), 5.5 (Consul and DynamoDB)" for Ruby.
Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
Requirements
Note: This is a metadata-only change that doesn't require test coverage or platform validation.
Related issues
N/A - This is a metadata update to document SDK features.
Describe the solution you've provided
This PR adds a
featuresobject to.sdk_metadata.jsondocumenting all the features supported by the Ruby Server SDK and the version in which each was introduced. The feature list was derived from the SDK features documentation and uses canonical feature names from feature_info.json.Features documented (24 total):
allFlags,appMetadata,bigSegments,contexts,experimentation,fileDataSource,flagChanges,hooks,inlineContextFeatureEvents,migrations,offlineMode,omitAnonContexts,otel,privateAttrs,relayProxyDaemon,relayProxyProxy,secureMode,storingData,storingDataConsul,storingDataDynamodb,storingDataRedis,testDataSource,track,variationDetail,webProxyDescribe alternatives you've considered
N/A
Additional context
feature_info.jsonstoringDataConsul,storingDataDynamodb,storingDataRedis) were added to sdk-meta in PR #328 (now merged)Updates since last revision
Updated feature versions to include patch versions where the documentation specifies them:
allFlags: 2.0.1fileDataSource: 5.4.1secureMode: 2.0.1storingData: 2.3.1storingDataRedis: 2.3.1webProxy: 2.2.5Human review checklist
inlineContextFeatureEventsversion (8.3) is correct - this is for feature/evaluation events per CHANGELOG 8.3.0, distinct from "Inline contexts in custom events" (8.9) in the docsRequested by: @jsonbailey
Link to Devin run: https://app.devin.ai/sessions/49b44fe704ac4382802b7b3dc07970a6