feat(--cpus): add support for --cpus flag#136
Open
PawanKumarA wants to merge 1 commit intolavie:masterfrom
Open
feat(--cpus): add support for --cpus flag#136PawanKumarA wants to merge 1 commit intolavie:masterfrom
PawanKumarA wants to merge 1 commit intolavie:masterfrom
Conversation
This commit adds support for the --cpus flag, allowing users to reproduce container CPU limits. The `docker inspect` command outputs this value as `NanoCpus`, an integer. However, the `docker run` command expects a floating-point number for the `--cpus` flag. This implementation correctly parses the `NanoCpus` integer and converts it to a floating-point number. For example, a value of 1,000,000,000 NanoCpus will be correctly represented as 1.0 in the generated `docker run` command.
Owner
|
Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for the --cpus flag, allowing users to reproduce container CPU limits. The
docker inspectcommand outputs this value asNanoCpus, an integer. However, thedocker runcommand expects a floating-point number for the--cpusflag.This implementation correctly parses the
NanoCpusinteger and converts it to a floating-point number. For example, a value of 1,000,000,000 NanoCpus will be correctly represented as 1.0 in the generateddocker runcommand.