feat: Add 'source_url' to news articles for original source attributi… #7228
Conversation
github-actions
bot
added
area/news
|
🚀 Preview for commit a49201e at: https://6934720953d25512b3111772--layer5.netlify.app |
|
@leecalcote , please review and give some feedback. |
src/collections/news/news-template/0000-00-00-news-title/index.mdx
Outdated
Show resolved
Hide resolved
leecalcote
left a comment
leecalcote
left a comment
There was a problem hiding this comment.
@rishiraj38, thank you. Will you please:
- Confirm that the optional aspect of this property is supported?
- For each published item in our news collection, add its source_url, if one is included (most should have one).
|
This is looking real good otherwise, @rishiraj38 👍 |
|
@leecalcote Yes, |
|
🚀 Preview for commit c9fc75e at: https://6935782cc211bb3da70ebb7b--layer5.netlify.app |
|
@rishiraj38 Thank you for your contribution! Let's discuss this during the website call tomorrow at 6:30 PM IST | 8 AM CT Add it as an agenda item to the meeting minutes, if you would 🙂 |
leecalcote
left a comment
leecalcote
left a comment
There was a problem hiding this comment.
@rishiraj38, send word when you have updated each item in the news collection with their respective source_url.
rishiraj38
force-pushed
the
feat/news-source-url
branch
from
2d4b0b7 to
a3362c7
Compare
|
🚀 Preview for commit b73e5c2 at: https://69367db053d25577e31116d2--layer5.netlify.app |
|
@leecalcote ,please provide some feedback. |
|
@rishiraj38 |
|
🚀 Preview for commit cd38790 at: https://69370aec4fa46d596b5f4da7--layer5.netlify.app |
Best that you describe what changes you've made, so that I'm aware of what, specifically, you're looking for feedback on, @rishiraj38 |
| thumbnail: "./what-the-numbers-say-about-how-service-meshes-are-used-today.webp" | ||
| darkthumbnail: "./what-the-numbers-say-about-how-service-meshes-are-used-today.webp" | ||
| eurl: https://thenewstack.io/what-the-numbers-say-about-how-service-meshes-are-used-today/ | ||
| source_url: https://thenewstack.io/what-the-numbers-say-about-how-service-meshes-are-used-today/ |
| thumbnail: ./service-mesh-implementations.webp | ||
| darkthumbnail: ./service-mesh-implementations.webp | ||
| eurl: https://thenewstack.io/kubeconcloudnativecon-service-mesh-battle-stories-and-fixes/ | ||
| source_url: https://thenewstack.io/kubeconcloudnativecon-service-mesh-battle-stories-and-fixes/ |
github-actions
bot
added
project/meshery
area/blog
rishiraj38
force-pushed
the
feat/news-source-url
branch
3 times, most recently
from
4b896a9 to
f68b8c0
Compare
|
@Rajesh-Nagarajan-11 I don’t know what’s happening. The DCO is failing yet I’m making signed commits. |
rishiraj38
force-pushed
the
feat/news-source-url
branch
2 times, most recently
from
456afbf to
d614286
Compare
|
🚀 Preview for commit d614286 at: https://6937b4db9fe43cdf8c1e89c6--layer5.netlify.app |
|
I’ve added the source URL to the news article that contained an eurl. Now, what do I do with the news articles that don’t have eurl? |
Signed-off-by: l5io <ci@layer5.io> Signed-off-by: Rishi Raj <rishiraj438gt@gmail.com>
Signed-off-by: Rishi Raj <rishiraj438gt@gmail.com>
…and documentation, along with corresponding tests Signed-off-by: Rishi Raj <rishiraj438gt@gmail.com>
rishiraj38
force-pushed
the
feat/news-source-url
branch
from
b44f13e to
585c3d9
Compare
|
🚀 Preview for commit 585c3d9 at: https://6937e3fdced81c3cc5450e85--layer5.netlify.app |
5 participants
Description
This PR adds an optional
source_urlfield to the news article data model. This allows reprinted news articles to properly attribute and link back to the original source.Changes included:
source_urlfrom frontmatter.This fixes #7135.
Notes for Reviewers
You can verify this by checking any news article that has the
source_urlfield added to its frontmatter (none are added in this PR to keep it valid for existing content, but the template is updated for future use).Signed commits