Fix multitransport darwin #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laszlo Budai <laszlo.budai@balabit.com>
Signed-off-by: Laszlo Budai <laszlo.budai@balabit.com>
Signed-off-by: Laszlo Budai <laszlo.budai@balabit.com>
Signed-off-by: Laszlo Budai <laszlo.budai@balabit.com>
Signed-off-by: Laszlo Budai <laszlo.budai@balabit.com>
MultiTransport is responsible for switching between the supported LogTransport instances. MultiTransport is-a LogTransport which means that it can be used in any places where LogTransport can be used. Signed-off-by: Laszlo Budai <laszlo.budai@balabit.com>
Signed-off-by: Laszlo Budai <laszlo.budai@balabit.com>
Signed-off-by: Laszlo Budai <laszlo.budai@balabit.com>
In this case a logproto can do the runtime protocol switch. Signed-off-by: Laszlo Budai <laszlo.budai@balabit.com>
Signed-off-by: Laszlo Budai <laszlo.budai@balabit.com>
Signed-off-by: Laszlo Budai <laszlo.budai@balabit.com>
Signed-off-by: Laszlo Budai <laszlo.budai@balabit.com>
Signed-off-by: Laszlo Budai <laszlo.budai@balabit.com>
Signed-off-by: Laszlo Budai <laszlo.budai@balabit.com>
lbudai
force-pushed
the
fix-multitransport-darwin
branch
from
254dae4 to
3798678
Compare
Signed-off-by: Laszlo Budai <laszlo.budai@balabit.com>
lbudai
force-pushed
the
fix-multitransport-darwin
branch
from
3798678 to
7de3b2e
Compare
Caught by functest where TLS is configured by using the legacy TCP driver. The problem was that Multitransport was constructed with default plain TCP transport and TLS related tests stalled. The fix: Construct TLS transport when legacy TCP is used with TLS. When transport() is not used and we have TLS context it means that user configured TLS with legacy TCP driver. Signed-off-by: Laszlo Budai <laszlo.budai@balabit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.