convierte clientes.php en restful#18
Open
dragonnegro78 wants to merge 9 commits intopractica-modulo3from
Open
Conversation
agrego un archivo para levantar la tabla en mysql y cargar todos los clientes del json.
…lo funcionaba si se tenia el .json
borro condicion que detectaba cuando ya no habia mas clientes y bloqueaba el boton de busqueda porque ahora se pueden agregar clientes una vez vacia completamente la base de datos
index.html: agrego alerts para la pestaña de nuevo cliente
…final de ambas listas clientes.php: faltaban comprobaciones de que algunos inputs sean numeros
Owner
There was a problem hiding this comment.
Haciendo esto la información no viaja en JSON, pero no importa, dejalo así. Yo también lo hice así, sólo quería contarte.
Owner
|
@dragonnegro78 bueno, tenés banda de tarea para hacer, pero fijate que la mayoría de las cosas fueron comentarios perfeccionistas. Está muy bueno, te felicito. @ToadMaster @alvarezhm Aprendan, giles. |
Collaborator
Author
|
Re que lea solo me marco mas comentarios que en cualquier otro PR entre todos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.