Minor metrics specification fixes #21
Open
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renamed `lean_pq_sig_attestation_signing_time_seconds` to `lean_pq_signature_attestation_signing_time_seconds` and `lean_pq_sig_attestation_verification_time_seconds` to `lean_pq_signature_attestation_verification_time_seconds`, as those are the metric names that grafana dashboard in development/client-dashboard.json references, as well as what both ream and zeam implement; * removed buckets from `lean_pq_sig_aggregated_signatures_total` and `lean_pq_sig_attestations_in_aggregated_signatures_total` metrics, as those have `Counter` type; * fixed `lean_pq_sig_attestation_signatures_building_time_seconds` metric description, to say "build" instead of "verify" signature; * for aggregate signature metrics, changed event from "On `build_attestation_signatures()`" to "On aggregated attestation production", as this function in specification is used only for tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lean_pq_sig_attestation_signing_time_secondstolean_pq_signature_attestation_signing_time_secondsandlean_pq_sig_attestation_verification_time_secondstolean_pq_signature_attestation_verification_time_seconds, as those are the metric names that grafana dashboard in development/client-dashboard.json references, as well as what both ream and zeam implement;lean_pq_sig_aggregated_signatures_totalandlean_pq_sig_attestations_in_aggregated_signatures_totalmetrics, as those haveCountertype;lean_pq_sig_attestation_signatures_building_time_secondsmetric description, to say "build" instead of "verify" signature;build_attestation_signatures()" to "On aggregated attestation production", as this function in specification is used only for tests.