Skip to content

feat(tray_manager): support menu item icons on macOS #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sichang824 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(tray_manager): support menu item icons on macOS #91

sichang824 wants to merge 2 commits into from

Conversation

@sichang824
Copy link

@sichang824 sichang824 commented Dec 19, 2025 •
edited
Loading

What

  • Add macOS support for per-menu-item icons in tray menus via MenuItem.icon.

How

  • On macOS, setContextMenu now loads MenuItem.icon from Flutter assets, encodes it as base64, and sends it to native as base64Icon.
  • Native macOS (TrayMenu.swift) decodes base64Icon and sets NSMenuItem.image.
  • Fallback: if base64Icon is unavailable, treat icon as an absolute file path (best-effort).

Demo

  • Updated example menu items to include: icon: images/tray_icon.png
  • Added screenshots:
    • screenshots/macos_icon.png
    • screenshots/macos_icon1.png

Notes

  • Other platforms may ignore MenuItem.icon for now.

@sichang824
feat(tray_manager): support menu item icons on macOS
f529bea 
Render per-menu-item icons in macOS tray menus by passing icon assets as base64 to native and setting NSMenuItem.image.\n\nAlso update example and docs to demonstrate MenuItem.icon usage.
@sichang824
docs(tray_manager): improve menu icon docs
4dcd008 
Use GitHub raw links for screenshots, avoid manual doctoc edits, add changelog entry, and cache base64 icon encoding on macOS.
@sichang824 sichang824 mentioned this pull request Dec 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sichang824