-
Notifications
You must be signed in to change notification settings - Fork 48
Replace markdown with pulldown-cmark #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! Unfortunately, the line wrapping and indentation is a bit wonky with this change. |
Contributor
Author
|
@Kha sorry for the long delay in getting back to this. I think I've fixed it now. How does this look? (N.B. I've added in bullet points for the list, which were missing before.) |
Contributor
Author
|
Post install message before: Post install message now: |
Member
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original markdown package is unmaintained [1]. There is apparently a replacement, but it is still in alpha [2]. rustup (from which elan was forked) switched to using pulldown-cmark [3] five years ago.
I am the Debian package maintainer for elan[4] and rust-markdown[5]. I've been asked [6] if elan can please drop the dependency on markdown in order that rust-markdown can be removed from Debian.
This PR is a port of [3a-d] to elan.
N.B. I am not a rust developer, but I have checked that this PR compiles.
[1] https://rustsec.org/advisories/RUSTSEC-2022-0044.html
[2] https://github.com/wooorm/markdown-rs
[3a] rust-lang/rustup#2009
[3b] rust-lang/rustup#3071
[3c] rust-lang/rustup#3662
[3d] rust-lang/rustup#3838
[4] https://packages.debian.org/sid/elan
[5] https://packages.debian.org/source/sid/rust-markdown
[6] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1040514#25