chore: Use ExceptT for error handling #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a triage to leanprover#8, adds some non-panic handling for the case where a constant to be dumped by name is not found in the environment. This should probably be considered an unrecoverable error in almost all scenarios, so it simply throws and terminates with an error message stating what declaration wasn't found, then terminates with a non-zero error code (1). For the other disallowed export items (mvar, fvar, mdata for now) which are currently marked `unreachable`, they might as well be handled with a little bit more information and similarly fail immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a triage to #8, adds some non-panic handling for the case where a constant to be dumped by name is not found in the environment. This should probably be considered an unrecoverable error in almost all scenarios, so it simply throws and terminates with an error message stating what declaration wasn't found, then terminates with a non-zero error code (1).
For the other disallowed export items (mvar, fvar, mdata for now) which are currently marked
unreachable, they might as well be handled with a little bit more information and similarly fail immediately.