Skip to content

Conversation

@rhen92
Copy link
Collaborator

@rhen92 rhen92 commented Jan 23, 2026

Overview

This PR updates the trusted issuer links to open in the in-app browser on native instead of leaving the app.

🎟 Relevant Jira Issues

https://welibrary.atlassian.net/browse/LC-1476

📚 What is the context and goal of this PR?

🥴 TL; RL:

💡 Feature Breakdown (screenshots & videos encouraged!)

Before

Screen.Recording.2026-01-23.at.2.14.17.PM.mov

After

Screen.Recording.2026-01-23.at.2.19.14.PM.mov

🛠 Important tradeoffs made:

🔍 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (refactor, documentation update, etc)

💳 Does This Create Any New Technical Debt? ( If yes, please describe and add JIRA TODOs )

  • No
  • Yes

Testing

🔬 How Can Someone QA This?

📱 🖥 Which devices would you like help testing on?

🧪 Code Coverage

Documentation

📝 Documentation Checklist

User-Facing Docs (docs/docs.learncard.com)

  • Tutorial — New capability that users need to learn (docs/tutorials/)
  • How-To Guide — New workflow or integration (docs/how-to-guides/)
  • Reference — New/changed API, config, or SDK method (docs/sdks/)
  • Concept — New mental model or architecture explanation (docs/core-concepts/)
  • App Flows — Changes to LearnCard App or ScoutPass user flows (docs/apps/)

Internal/AI Docs

  • CLAUDE.md — New pattern, flow, or context that AI assistants need
  • Code comments/JSDoc — Complex logic that needs inline explanation

Visual Documentation

  • Mermaid diagram — Complex flow, state machine, or architecture

💭 Documentation Notes

✅ PR Checklist

  • Related to a Jira issue (create one if not)
  • My code follows style guidelines (eslint / prettier)
  • I have manually tested common end-2-end cases
  • I have reviewed my code
  • I have commented my code, particularly where ambiguous
  • New and existing unit tests pass locally with my changes
  • I have completed the Documentation Checklist above (or explained why N/A)

🚀 Ready to squash-and-merge?:

  • Code is backwards compatible
  • There is not a "Do Not Merge" label on this PR
  • I have thoughtfully considered the security implications of this change.
  • This change does not expose new public facing endpoints that do not have authentication

✨ PR Description

Purpose: Replace standard anchor tags with in-app browser navigation for trusted issuer links to improve native app user experience and maintain app context.

Main changes:

  • Imported openExternalLink helper function to handle cross-platform link opening behavior
  • Converted three anchor tags to button elements with onClick handlers for documentation and issuer URLs
  • Removed target="_blank" and rel attributes from links to prevent external browser navigation on native platforms

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

@netlify
Copy link

netlify bot commented Jan 23, 2026

Deploy Preview for learncarddocs canceled.

Name Link
🔨 Latest commit 5aaab39
🔍 Latest deploy log https://app.netlify.com/projects/learncarddocs/deploys/6977a1f5a9bbab0008112fb9

@netlify
Copy link

netlify bot commented Jan 23, 2026

Deploy Preview for staging-learncardapp failed. Why did it fail? →

Name Link
🔨 Latest commit 5aaab39
🔍 Latest deploy log https://app.netlify.com/projects/staging-learncardapp/deploys/6977a1f5caa143000874ffd2

@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2026

🦋 Changeset detected

Latest commit: 5aaab39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
learn-card-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

👋 Hey there! It looks like you modified code, but didn't update the documentation in /docs.

If this PR introduces new features, changes APIs, or modifies behavior that users or developers need to know about, please consider updating the docs.


🏄 Windsurf Tip

You can ask Windsurf to help:

"Analyze the changes in this PR and update the gitbook docs in /docs accordingly."

Windsurf will review your changes and suggest appropriate documentation updates based on what was modified.


📚 Documentation Guide
Change Type Doc Location
New feature/API docs/tutorials/ or docs/how-to-guides/
SDK/API changes docs/sdks/
New concepts docs/core-concepts/
App UI/UX flows docs/apps/ (LearnCard App, ScoutPass)
Internal patterns CLAUDE.md

This is an automated reminder. If no docs are needed, feel free to ignore this message.

Copy link
Contributor

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ PR Review

LGTM

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Review using Guidelines Learn how

@gitstream-cm
Copy link
Contributor

gitstream-cm bot commented Jan 23, 2026

🥷 Code experts: TaylorBeeston

TaylorBeeston has most 👩‍💻 activity in the files.
TaylorBeeston has most 🧠 knowledge in the files.

See details

apps/learn-card-app/src/components/boost/boostCMS/BoostPreview/CredentialIssuerInformation.tsx

Activity based on git-commit:

TaylorBeeston
JAN
DEC
NOV 138 additions & 0 deletions
OCT
SEP
AUG

Knowledge based on git-blame:
TaylorBeeston: 100%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

Copy link
Collaborator

@goblincore goblincore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rhen92 rhen92 merged commit 819bd73 into main Jan 26, 2026
18 of 23 checks passed
@rhen92 rhen92 deleted the lc-1476 branch January 26, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants