Skip to content

Add simple CI#39

Open
a-r-j wants to merge 6 commits intomainfrom
CI_CD
Open

Add simple CI#39
a-r-j wants to merge 6 commits intomainfrom
CI_CD

Conversation

@a-r-j
Copy link
Collaborator

@a-r-j a-r-j commented Dec 9, 2022

No description provided.

@a-r-j
Copy link
Collaborator Author

a-r-j commented Dec 9, 2022

Not sure how you want to proceed wrt gpflow. It doesn't seem like it's used a lot; mostly for some array utils. It would probably be a good idea to just implement those utils and remove the dependency.

@a-r-j a-r-j requested a review from Ryan-Rhys December 9, 2022 16:09
@a-r-j a-r-j added the CI label Dec 9, 2022
@Ryan-Rhys
Copy link
Collaborator

Ryan-Rhys commented Jan 5, 2023

Looks like we can merge once conflicts are resolved. The gpflow dependency is used for some tests

@a-r-j
Copy link
Collaborator Author

a-r-j commented Jan 5, 2023 •
edited
Loading

Looks like we can merge once conflicts are resolved. The gpflow dependency is used for some tests

This can be separated too e.g.:

https://github.com/pyg-team/pytorch_geometric/blob/0758c92988ad31937c3a909c9741023c0bebd494/setup.py#L50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ryan-Rhys Ryan-Rhys Awaiting requested review from Ryan-Rhys

Assignees

No one assigned

Labels

CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a-r-j @Ryan-Rhys