feat: OIDC group-to-role mapping and various improvements#5
Merged
leonmeijer merged 2 commits intomainfrom Jan 17, 2026
Merged
Conversation
OIDC Group Mapping: - Add automatic role assignment based on OIDC group membership - Support global admin groups via OIDC_ADMIN_GROUPS env var - Add OIDC_ROLE_CLAIM config for custom group claim name - Add OIDC_SYNC_ROLES_ON_LOGIN to sync roles on every login - New Settings > OIDC Groups page for UI configuration - Support both env var config and per-environment database config - Auto-create database record when saving with global OIDC config Backend: - Add group mapping fields to oidc_providers table (migration 007) - Update auth service with group extraction and role mapping logic - Add OIDC provider CRUD endpoints for environment configuration - Make PULSAR_CLUSTER configurable via environment variable Frontend: - Add OIDCSettingsPage for group mapping configuration - Add OIDC Groups navigation item in sidebar - Update API hooks and types for OIDC provider config Documentation: - Update README with OIDC group mapping documentation - Add .env.example with all configuration options Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove hardcoded JWT token from test_producer.py, use env vars instead - Fix admin revocation bug: actually revoke is_global_admin when user leaves admin OIDC groups (was a no-op pass statement) - Extract duplicated formatBytes to shared utility src/lib/format.ts - Fix N+1 query in topic listing with asyncio.gather parallel batching Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OIDC_ADMIN_GROUPSenv varAdditional Improvements (on top of original PR #4)
is_global_adminwhen user leaves admin OIDC groupsformatBytesto shared utilitysrc/lib/format.tsasyncio.gatherparallel batchingNew Environment Variables
OIDC_ROLE_CLAIMgroupsOIDC_ADMIN_GROUPSOIDC_SYNC_ROLES_ON_LOGINtruePULSAR_CLUSTERstandaloneTest plan
OIDC_ADMIN_GROUPS=adminsand verify users in that group become global adminsBased on PR #4 by @pezzking
🤖 Generated with Claude Code