Core: Updating all packages within the project to their most up to date versions#36
Open
AndrewLowther wants to merge 13 commits intoleozdgao:masterfrom
Open
Core: Updating all packages within the project to their most up to date versions#36AndrewLowther wants to merge 13 commits intoleozdgao:masterfrom
AndrewLowther wants to merge 13 commits intoleozdgao:masterfrom
Conversation
Detailed: The modules in use on this project were seriously out of date, and represented a potential security risk on websites currently using it. I have updated all modules to their most modern versions possible, and fixed tests within the application, alongside the build process to ensure security is maintained. Signed-off-by: Andrew Lowther <Andrew.Lowther@gentinguk.com>
Signed-off-by: Andrew Lowther <Andrew.Lowther@gentinguk.com>
Signed-off-by: Andrew Lowther <Andrew.Lowther@gentinguk.com>
Author
|
Author
|
@leozdgao May I have a review on this please? |
Branch: feature/package-updates
Signed-off-by: Andrew Lowther <Andrew.Lowther@gentinguk.com>
Signed-off-by: Andrew Lowther <Andrew.Lowther@gentinguk.com>
`onScriptLoaded` should be added to `ScriptLoader` instead of `scriptLoader`, otherwise it will throw error 'onScriptLoaded is undefined' when it is not provided.
Fix 'onScriptLoaded is undefined'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed:
The modules in use on this project were seriously out of date, and
represented a potential security risk on websites currently using it.
I have updated all modules to their most modern versions possible,
and fixed tests within the application, alongside the build process
to ensure security is maintained.
Signed-off-by: Andrew Lowther Andrew.Lowther@gentinguk.com