This repository was archived by the owner on Oct 6, 2024. It is now read-only.
fix issue#63: make dependency markit upgrade to 0.2.0 and fixed post title parsing problem#65
Open
qhhonx wants to merge 2 commits intolepture:masterfrom
qhhonx:master
Open
fix issue#63: make dependency markit upgrade to 0.2.0 and fixed post title parsing problem#65qhhonx wants to merge 2 commits intolepture:masterfrom qhhonx:master
markit upgrade to 0.2.0 and fixed post title parsing problem#65qhhonx wants to merge 2 commits intolepture:masterfrom
qhhonx:master
Conversation
…t title parsing problem `markit` v0.2.0 does generate head tag code snippet with id attribute which leads to `html.match(/<h1>(.*?)<\/h1>/);` can not match anything.
Owner
|
@xohozu Can you fix the test cases? It seems that |
Author
|
@lepture I checked the newest api document of
I can not solve these problems in a short time because this is the first time I read nodejs codes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
markitv0.2.0 does generate head tag code snippet with id attribute which leads tohtml.match(/<h1>(.*?)<\/h1>/);can not match anything.