Define CONFIG_ESP32_SPI_AVAILABLE if ESP32 is defined #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like this def was placed in too broad a scope in #1e25600 I don't have an esp32 handy to test on however it should still be defined on an ESP32. The ESP31B will no longer have it defined. This was a beta chip and I cannot find information if it supports SPI2. I also fixed a comment that was incorrect since the initial commit. fixes #88 fixes #111 fixes #93
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this def was placed in too broad a scope in 1e25600
I don't have an esp32 handy to test on however it should still be defined on an ESP32. The ESP31B will no longer have it defined. This was a beta chip and I cannot find information if it supports SPI2.
I also fixed a comment that was incorrect since the initial commit.
fixes #88
fixes #111
fixes #93