Enable strict node scheduling for cluster app instances. #5508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
OhmSpectator,
eriknordmark,
milan-zededa,
naiming-zededa,
rene,
rouming,
rucoder,
shjala,
uncleDecart and
zedi-pramodh
andrewd-zededa
force-pushed
the
eve-k-node-affinity
branch
4 times, most recently
from
8667057 to
f9a3f79
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5508 +/- ##
==========================================
+ Coverage 19.52% 28.08% +8.55%
==========================================
Files 19 19
Lines 3021 2314 -707
==========================================
+ Hits 590 650 +60
+ Misses 2310 1520 -790
- Partials 121 144 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrewd-zededa
force-pushed
the
eve-k-node-affinity
branch
from
f9a3f79 to
9bcf24e
Compare
Contributor
Author
|
Replaced the placeholder commit with the real vendored eve-api which recently merged. |
App wil only run if scheduling succeeds for the requested node id. Set DesignatedNodeID and AffinityType Required. With strict node scheduling the app will not failover to other cluster nodes. Signed-off-by: Andrew Durbin <andrewd@zededa.com>
go get github.com/lf-edge/eve-api/go@4149b9d go mod tidy go mod vendor Signed-off-by: Andrew Durbin <andrewd@zededa.com>
andrewd-zededa
force-pushed
the
eve-k-node-affinity
branch
from
9bcf24e to
05ce048
Compare
Contributor
Author
|
Rebased off master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently VM app instances are set with a default node affinity 'preferred' which attempts to schedule to the DesignatedNodeID but can allow the app instance to fail over to another heathy node.
This PR enhances DesignatedNodeID with an affinity type to allow for required node affinity which will only run the app instance if the DesignatedNodeID is available and healthy, this also disables failover for the app instance.
PR dependencies
EVE-API: lf-edge/eve-api#130
How to test and validate this PR
Changelog notes
Enable strict node scheduling for app instances on clustered HV=k EVE-OS nodes.
PR Backports
Checklist
And the last but not least:
check them.
Please, check the boxes above after submitting the PR in interactive mode.