-
Notifications
You must be signed in to change notification settings - Fork 177
Change Edgeview Token Hash size to full 256-bit SHA-256 #5541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Change Edgeview Token Hash size to full 256-bit SHA-256 #5541
Conversation
7bd4fca to
f9ecabc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5541 +/- ##
==========================================
+ Coverage 19.52% 28.08% +8.55%
==========================================
Files 19 19
Lines 3021 2314 -707
==========================================
+ Hits 590 650 +60
+ Misses 2310 1520 -790
- Partials 121 144 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eriknordmark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
But I don't understand the text in the description about needing to keep the fallback around until all EVE nodes being updated. Isn't it all the dispatchers which need to be updated? [If so, can we release updated dispatcher containers and push for folks to run the latest to reduce the amount of time we need to keep the fallback in place.]
No, the encryption here is on the payload of edgeview message, which is transparent to dispatcher. The idea is if the dispatcher is compromised, the hacker still can not decode the edgeview message. |
Does that mean that the all edgeview clients need to be updated before we can remove the short key support from EVE? |
yes. so I'm really wondering if we should do this PR or not. |
- a simple change, but would break the backwords compatibility due to EVE devices may continue to run with the older version images - this patch will for now, try the full size first, if we don't get a match, then tried the original hash size of the token. We can remove the short version later on if we are sure all the EVE devices are upgraded to at least this version - the dispatch currently supports 'probing' message, this patch utilize this feature to probing to see which size we are going to use. Signed-off-by: naiming-zededa <naiming@zededa.com>
f9ecabc to
d1812a2
Compare
Description
PR dependencies
How to test and validate this PR
Changelog notes
Change Edgeview Token Hash size to full 256-bit SHA-256
PR Backports
Checklist
For backport PRs (remove it if it's not a backport):
And the last but not least:
check them.